public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gordon Oliver <gordo@pincoya.com>
To: Robert Love <rml@tech9.net>
Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] console close race fix resend
Date: Mon, 10 Dec 2001 19:16:30 -0800	[thread overview]
Message-ID: <20011210191630.A13679@furble> (raw)
In-Reply-To: <1008035512.4287.1.camel@phantasy>
In-Reply-To: <1008035512.4287.1.camel@phantasy>; from rml@tech9.net on Mon, Dec 10, 2001 at 17:51:51 -0800


On 2001.12.10 17:51 Robert Love wrote:
> Marcelo,
> 
> [ Resend of previous patch, now against pre8.  Note it (a) is a bug fix
> and (b) was in Alan's tree ]

and (c) appears to still have a race... You should extract
the value from the structure inside the lock, otherwise you
will still race with con_close (though perhaps a smaller race)
but since the call to acquire_console_sem() can sleep, the
vt handle you have may be stale.

> Please, for all that is righteous, apply.

please fix it better first...
(unless I am mistaken).
	-gordo


  reply	other threads:[~2001-12-11  3:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-11  1:51 [PATCH] console close race fix resend Robert Love
2001-12-11  3:16 ` Gordon Oliver [this message]
2001-12-11  6:05   ` Robert Love
2001-12-11  6:28     ` Andrew Morton
2001-12-11  9:05       ` [PATCH] " Robert Love
2001-12-11  8:54     ` [PATCH] " Gordon Oliver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011210191630.A13679@furble \
    --to=gordo@pincoya.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=rml@tech9.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox