From: Benjamin LaHaise <bcrl@redhat.com>
To: Steven Walter <srwalter@yahoo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v2.5.1-pre9-00_kvec.diff
Date: Tue, 11 Dec 2001 22:37:11 -0500 [thread overview]
Message-ID: <20011211223711.C17550@redhat.com> (raw)
In-Reply-To: <20011211162639.F6878@redhat.com> <20011211213515.D29224@hapablap.dyn.dhs.org>
In-Reply-To: <20011211213515.D29224@hapablap.dyn.dhs.org>; from srwalter@yahoo.com on Tue, Dec 11, 2001 at 09:35:15PM -0600
On Tue, Dec 11, 2001 at 09:35:15PM -0600, Steven Walter wrote:
> > + nr_pages = (ptr + len + PAGE_SIZE - 1) >> PAGE_SHIFT;
> > + nr_pages -= ptr >> PAGE_SHIFT;
>
> Isn't this the same as
> nr_pages = (len + PAGE_SIZE -1) >> PAGE_SHIFT;
No.
> ? Or am I missing something?
Yes. Pointers may not be page aligned.
-ben
--
Fish.
next prev parent reply other threads:[~2001-12-12 3:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-11 21:26 [PATCH] v2.5.1-pre9-00_kvec.diff Benjamin LaHaise
2001-12-11 23:33 ` Hugh Dickins
2001-12-11 23:41 ` Benjamin LaHaise
2001-12-12 21:24 ` Benjamin LaHaise
2001-12-13 16:11 ` Hugh Dickins
2001-12-12 3:35 ` Steven Walter
2001-12-12 3:37 ` Benjamin LaHaise [this message]
2001-12-12 16:04 ` Roman Zippel
2001-12-12 18:47 ` [PATCH] v2.5.1-pre10-01_kvec.diff Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011211223711.C17550@redhat.com \
--to=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srwalter@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox