From: Stephan von Krawczynski <skraw@ithnet.com>
To: Tim Hockin <thockin@hockin.org>
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
xi@borderworlds.dk (Christian Laursen),
linux-kernel@vger.kernel.org
Subject: Re: NULL pointer dereference in moxa driver
Date: Wed, 12 Dec 2001 03:48:39 +0100 [thread overview]
Message-ID: <200112120248.DAA24783@webserver.ithnet.com> (raw)
In-Reply-To: <200112112329.fBBNTqc13889@www.hockin.org>
> > There is no maintainer, and our code base has drifted a fair way
from what
> > moxa originally submitted (being a 2.0 driver with the serial
transmit race
> > bug).
> >
> > Anyone who wants to beat the mxser driver into shape, go for it.
>
> I'm using it under 2.4.x, but I missed the rest of this thread -
what are
> the issues?
Ok. Short summary (on mxser, moxa is different):
- multiple board support is broken
- driver blows up on illegal device minor numbers opened
- no security checks whatsoever on internal array overflows
- Completely broken port-number setup
- No visible NULL-pointer checks regarding dynamic structures
It looks like original taiwanese work: it is usable, but there are so
many dead ends in this code, you won't believe - and I did only look
some few minutes on it.
It desperately needs cleanup.
Listen Tim, if you want to do it, I can help you. But keep in mind, I
have no hardware. So I am probably not the right guy for maintenance.
If you do not feel comfortable, I will try it.
Regards,
Stephan
next prev parent reply other threads:[~2001-12-12 2:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m37krtl6cv.fsf@borg.borderworlds.dk>
2001-12-11 23:23 ` NULL pointer dereference in moxa driver Stephan von Krawczynski
2001-12-11 23:51 ` Alan Cox
2001-12-11 23:29 ` Tim Hockin
2001-12-12 2:48 ` Stephan von Krawczynski [this message]
2001-12-11 23:58 ` Christian Laursen
2001-12-10 17:53 Christian Laursen
2001-12-10 18:26 ` Christian Laursen
2001-12-10 18:40 ` Stephan von Krawczynski
2001-12-10 19:12 ` Christian Laursen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200112120248.DAA24783@webserver.ithnet.com \
--to=skraw@ithnet.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=thockin@hockin.org \
--cc=xi@borderworlds.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox