From: Benjamin LaHaise <bcrl@redhat.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Big Fish <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] v2.5.1-pre9-00_kvec.diff
Date: Wed, 12 Dec 2001 16:24:12 -0500 [thread overview]
Message-ID: <20011212162412.A28056@redhat.com> (raw)
In-Reply-To: <20011211162639.F6878@redhat.com> <Pine.LNX.4.21.0112112324280.981-100000@localhost.localdomain>
In-Reply-To: <Pine.LNX.4.21.0112112324280.981-100000@localhost.localdomain>; from hugh@veritas.com on Tue, Dec 11, 2001 at 11:33:32PM +0000
On Tue, Dec 11, 2001 at 11:33:32PM +0000, Hugh Dickins wrote:
> Looks nice, but I think you need to update from atomic_inc(&map->count)
> and __free_page(map) to page_cache_get(map) and page_cache_release(map)?
> I haven't checked a 2.5.1-pre9 tree, but we had to change that in 2.4,
> to avoid PageLRU BUGs. page_cache_get end just tidiness, of course.
Hrm, the more I look at things, the more I'm convinced that this is wrong:
right now in the network code and other places we will use put_page() to
release a reference to a potential page cache page which could cause the
PageLRU BUG() to hit. I'm sure there are lots of subtle cases like this
all over the tree that the change in semantics has introduced bugs in.
-ben
--
Fish.
next prev parent reply other threads:[~2001-12-12 21:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-11 21:26 [PATCH] v2.5.1-pre9-00_kvec.diff Benjamin LaHaise
2001-12-11 23:33 ` Hugh Dickins
2001-12-11 23:41 ` Benjamin LaHaise
2001-12-12 21:24 ` Benjamin LaHaise [this message]
2001-12-13 16:11 ` Hugh Dickins
2001-12-12 3:35 ` Steven Walter
2001-12-12 3:37 ` Benjamin LaHaise
2001-12-12 16:04 ` Roman Zippel
2001-12-12 18:47 ` [PATCH] v2.5.1-pre10-01_kvec.diff Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011212162412.A28056@redhat.com \
--to=bcrl@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox