From: "David S. Miller" <davem@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: axboe@suse.de
Subject: that stupid aic7xxx AHC_NSEGS bug
Date: Thu, 13 Dec 2001 12:42:05 -0800 (PST) [thread overview]
Message-ID: <20011213.124205.38323630.davem@redhat.com> (raw)
We simply forget to initialize scb->sg_count in the non use_sg
case, so if the previous usage of that scb has sg_count==AHC_NSEGS
then we'd hit that panic erroneously. Here is the fix below.
"It can't possibly be my driver, something broke in some Linux
subsystem which is making my driver break", sheesh get over it
Justin...
--- drivers/scsi/aic7xxx/aic7xxx_linux.c.~1~ Fri Dec 7 22:54:31 2001
+++ drivers/scsi/aic7xxx/aic7xxx_linux.c Thu Dec 13 12:38:30 2001
@@ -1699,6 +1699,7 @@
cmd->request_buffer,
cmd->request_bufflen,
scsi_to_pci_dma_dir(cmd->sc_data_direction));
+ scb->sg_count = 0;
scb->sg_count = ahc_linux_map_seg(ahc, scb,
sg, addr,
cmd->request_bufflen);
next reply other threads:[~2001-12-13 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-13 20:42 David S. Miller [this message]
2001-12-13 20:57 ` that stupid aic7xxx AHC_NSEGS bug Justin T. Gibbs
2001-12-13 21:10 ` David S. Miller
2001-12-13 21:13 ` Justin T. Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011213.124205.38323630.davem@redhat.com \
--to=davem@redhat.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox