From: Andi Kleen <ak@suse.de>
To: Manfred Spraul <manfred@colorfullife.com>,
linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: optimize DNAME_INLINE_LEN
Date: Fri, 14 Dec 2001 00:29:57 +0100 [thread overview]
Message-ID: <20011214002957.A24984@wotan.suse.de> (raw)
In-Reply-To: <3C192A37.4547D2A7@colorfullife.com> <20011213160706.E940@lynx.no>
In-Reply-To: <20011213160706.E940@lynx.no>
On Thu, Dec 13, 2001 at 04:07:06PM -0700, Andreas Dilger wrote:
> Alternately (also ugly) you could just define struct dentry the as now,
> but have a fixed size declaration for d_iname, like:
>
> #define DNAME_INLINE_MIN 16
>
> unsigned char d_iname[DNAME_INLINE_MIN];
Using [0] here would also work
and fixing other code to add DNAME_INLINE_MIN as needed. Unfortunately
this "fixing other code" would likely prevent the patch going into 2.4,
which would be bad.
#define d_... has a similar problem => the potential to break previously
compiling source code.
Probably just using an compiler #ifdef is best, and perhaps doing it
cleanly (with using d_iname[0]) on 2.5.
-Andi
P.S.: I originally picked the 16 number and it was totally arbitary, so
an increase on the fallback to 20-30 would be likely ok.
next prev parent reply other threads:[~2001-12-13 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-13 22:22 optimize DNAME_INLINE_LEN Manfred Spraul
2001-12-13 23:07 ` Andreas Dilger
2001-12-13 23:24 ` Manfred Spraul
2001-12-13 23:29 ` Andi Kleen [this message]
2001-12-14 0:03 ` Andreas Dilger
2001-12-14 0:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011214002957.A24984@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox