public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephan von Krawczynski <skraw@ithnet.com>
To: Yoshiki Hayashi <yoshiki@xemacs.org>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
	Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [PATCH] 2.4.16 Fix NULL pointer dereferencing in agpgart_be.c
Date: Mon, 17 Dec 2001 14:00:36 +0100	[thread overview]
Message-ID: <20011217140036.4a0e8969.skraw@ithnet.com> (raw)
In-Reply-To: <87zo4iroxw.fsf@u.sanpo.t.u-tokyo.ac.jp>
In-Reply-To: <87zo4iroxw.fsf@u.sanpo.t.u-tokyo.ac.jp>

On 17 Dec 2001 21:50:03 +0900
Yoshiki Hayashi <yoshiki@xemacs.org> wrote:

> This patch is against 2.4.16.  I couldn't find maintainer in
> MAINTAINERS file so I'm simply sending this to Linus and
> linux-kernel list.
> 
> In apggart_be.c, if the chip is i830M and the secondary device is not
> found, linux kernel tries to dereference NULL pointer.  It checks NULL
> and returns from the function in the next statement but it's too late.
> 
> The attached patch add NULL check before dereferencing the
> pointer to fix the problem.

This was solved some weeks ago and the patch is pending somewhere (marcelo?).
Unfortunately the complete cure is inside this pending patch, because there are
other small tweaks for i830M. The NULL-check is sufficient for non-oops, but
i830-register size is smaller than the further ongoings inside agpgart_be.c.

Regards,
Stephan



  reply	other threads:[~2001-12-17 13:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-17 12:50 [PATCH] 2.4.16 Fix NULL pointer dereferencing in agpgart_be.c Yoshiki Hayashi
2001-12-17 13:00 ` Stephan von Krawczynski [this message]
2001-12-17 16:49   ` Marcelo Tosatti
2001-12-17 17:55     ` Marcelo Tosatti
2001-12-17 19:16       ` Robert Love
2001-12-17 23:17         ` Stephan von Krawczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011217140036.4a0e8969.skraw@ithnet.com \
    --to=skraw@ithnet.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    --cc=yoshiki@xemacs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox