public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Thomas Hood <jdthood@mail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: APM driver patch summary
Date: Tue, 18 Dec 2001 10:02:44 +0000	[thread overview]
Message-ID: <20011218100244.B12774@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1008638563.5515.96.camel@thanatos>
In-Reply-To: <1008638563.5515.96.camel@thanatos>; from jdthood@mail.com on Mon, Dec 17, 2001 at 08:22:40PM -0500

On Mon, Dec 17, 2001 at 08:22:40PM -0500, Thomas Hood wrote:
> Finally, think carefully about where the cli() and sti() should go.

I believe the cli() and sti() to be correct - you shouldn't call
pm_send_all with IRQs off as it was previously.  pm_send_all is a
function that can sleep (check the down(&pm_devs_lock) call).

--
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


  reply	other threads:[~2001-12-18 10:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-18  1:22 APM driver patch summary Thomas Hood
2001-12-18 10:02 ` Russell King [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-12-23  3:22 Thomas Hood
2001-12-23 12:12 ` Andreas Steinmetz
2001-12-22  3:35 Thomas Hood
2001-12-22 10:42 ` Andreas Steinmetz
2001-12-22 14:44 ` Andreas Steinmetz
2001-12-22 16:13   ` Thomas Hood
2002-01-04 19:56   ` Borsenkow Andrej
2002-01-05 11:58     ` Andreas Steinmetz
     [not found] <1008737165.1155.0.camel@thanatos>
2001-12-19 13:49 ` Thomas Hood
2001-12-18 21:46 Thomas Hood
2001-12-18 21:24 Thomas Hood
2001-12-18 21:42 ` Russell King
     [not found]   ` <E16GYl6-0000nz-00@phalynx>
2001-12-19 10:23     ` Russell King
2001-12-17 18:28 Thomas Hood
2001-12-17 22:04 ` Russell King
2001-12-17 22:22   ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011218100244.B12774@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=jdthood@mail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox