public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: acme@conectiva.com.br
Cc: SteveW@ACM.org, jschlst@samba.org, ncorbic@sangoma.com,
	eis@baty.hanse.de, dag@brattli.net, torvalds@transmeta.com,
	marcelo@conectiva.com.br, netdev@oss.sgi.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC 3] cleaning up struct sock
Date: Thu, 20 Dec 2001 00:21:26 -0800 (PST)	[thread overview]
Message-ID: <20011220.002126.119272610.davem@redhat.com> (raw)
In-Reply-To: <20011220012339.A919@conectiva.com.br>
In-Reply-To: <20011218.130809.22018359.davem@redhat.com> <20011218232222.A1963@conectiva.com.br> <20011220012339.A919@conectiva.com.br>

   From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
   Date: Thu, 20 Dec 2001 01:23:39 -0200

   Available at:
   
   http://www.kernel.org/pub/linux/kernel/people/acme/v2.5/2.5.1/
   sock.cleanup-2.5.1.patch.bz2

Looking pretty good.  I have one improvement.

I'd rather you pass the "kmem_cache_t" directly into sk_alloc, use
NULL for "I don't have any extra private area".

And then, for the IP case lay it out like this:

	struct sock
	struct ip_opt
	struct {tcp,raw4,...}_opt

And use different kmem_cache_t's for each protocol instead of
the same one for tcp, raw4, etc.

RAW/UDP sockets waste a lot of space with your current layout.

  reply	other threads:[~2001-12-20  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20011210230810.C896@conectiva.com.br>
     [not found] ` <20011210.231826.55509210.davem@redhat.com>
2001-12-18  5:35   ` [PATCH][RFC 2] cleaning up struct sock Arnaldo Carvalho de Melo
     [not found]     ` <20011217.225134.91313099.davem@redhat.com>
2001-12-18 12:01       ` Arnaldo Carvalho de Melo
2001-12-18 20:52       ` Arnaldo Carvalho de Melo
2001-12-18 21:08         ` David S. Miller
     [not found]           ` <20011218232222.A1963@conectiva.com.br>
2001-12-20  3:23             ` [PATCH][RFC 3] " Arnaldo Carvalho de Melo
2001-12-20  8:21               ` David S. Miller [this message]
2001-12-20 12:37                 ` Arnaldo Carvalho de Melo
2001-12-21 13:54                 ` Arnaldo Carvalho de Melo
2001-12-22  3:28                   ` [PATCH][RFC 4] " Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011220.002126.119272610.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=SteveW@ACM.org \
    --cc=acme@conectiva.com.br \
    --cc=dag@brattli.net \
    --cc=eis@baty.hanse.de \
    --cc=jschlst@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=ncorbic@sangoma.com \
    --cc=netdev@oss.sgi.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox