From: Jens Axboe <axboe@kernel.org>
To: Andrew Morton <akpm@zip.com.au>
Cc: William Lee Irwin III <wli@holomorphy.com>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: Poor performance during disk writes
Date: Fri, 21 Dec 2001 17:50:07 +0100 [thread overview]
Message-ID: <20011221175007.A2929@suse.de> (raw)
In-Reply-To: <20011220132729Z286241-18285+3296@vger.kernel.org>, <20011220132729Z286241-18285+3296@vger.kernel.org>; <20011220094025.B2632@holomorphy.com> <3C222BB5.B2CCC11B@zip.com.au>
In-Reply-To: <3C222BB5.B2CCC11B@zip.com.au>
On Thu, Dec 20 2001, Andrew Morton wrote:
> --- linux-2.4.17-pre6/drivers/block/ll_rw_blk.c Mon Nov 5 21:01:11 2001
> +++ linux-akpm/drivers/block/ll_rw_blk.c Sat Dec 8 11:10:36 2001
> @@ -690,7 +690,8 @@ again:
> } else if (q->head_active && !q->plugged)
> head = head->next;
>
> - el_ret = elevator->elevator_merge_fn(q, &req, head, bh, rw,max_sectors);
> + el_ret = elevator->elevator_merge_fn(q, &req, head, bh,
> + rw, max_sectors, elevator->max_bomb_segments);
merge function can just grab max_bomb_segments ala
int mbs = q->elevator.max_bomb_segments
so no need to modify the merge functions.
--
Jens Axboe
next prev parent reply other threads:[~2001-12-21 16:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-20 13:27 Poor performance during disk writes Dieter Nützel
2001-12-20 14:51 ` safemode
2001-12-20 17:40 ` William Lee Irwin III
2001-12-20 18:19 ` Andrew Morton
2001-12-20 18:29 ` Dave Jones
2001-12-21 16:50 ` Jens Axboe
2001-12-21 16:50 ` Jens Axboe [this message]
[not found] ` <0112201629230E.01835@manta>
[not found] ` <200112201436.fBKEa2m26640@zero.tech9.net>
2001-12-20 19:02 ` Robert Love
-- strict thread matches above, loose matches on Subject: below --
2001-12-18 0:53 jlm
2001-12-18 1:09 ` Reid Hekman
2001-12-18 1:36 ` jlm
2001-12-18 2:01 ` Reid Hekman
2001-12-18 18:46 ` Andre Hedrick
2001-12-18 17:42 ` Gérard Roudier
2001-12-18 20:34 ` Andre Hedrick
2001-12-18 19:09 ` Gérard Roudier
2001-12-19 23:26 ` jlm
2001-12-20 10:49 ` Helge Hafting
2001-12-21 16:29 ` Troy Benjegerdes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011221175007.A2929@suse.de \
--to=axboe@kernel.org \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox