Re: [RFC] [PATCH] Clean up fs.h union for ext2

Daniel Phillips
2001-12-27T03:49:26Z

On December 27, 2001 04:28 am, Legacy Fishtank wrote:
> On Thu, Dec 27, 2001 at 04:21:42AM +0100, Daniel Phillips wrote:
> > --- ../2.4.17.clean/include/linux/fs.h Fri Dec 21 12:42:03 2001
> > +++ ./include/linux/fs.h Wed Dec 26 23:30:55 2001
> > @@ -478,7 +478,7 @@
> > __u32 i_generation;
> > union {
> > struct minix_inode_info minix_i;
> > - struct ext2_inode_info ext2_i;
> > + struct ext2_inode_info ext2_inode_info;
> > struct ext3_inode_info ext3_i;
> > struct hpfs_inode_info hpfs_i;
> > struct ntfs_inode_info ntfs_i;
>
> Change in principle looks good except IMHO you should go ahead and
> remove the ext2 stuff from the union... (with the additional changes
> that implies)

Hi Jeff,

Thanks for your confidence, but that would be a considerably bigger patch.
It's not just a matter of removing the includes - other bits and pieces have
to be put in place, such as per-filesystem inode slab. The support for this
goes outside ext2.

My idea is to just let people have a look and test this minimally intrusive
change. Getting rid of the includes for ext2 inodes will be a two-patch
change:

1) Abstract away the ext2 .u's (done)
2) Per-fs inode slab, initially only for ext2 (partly done)

Removing the includes for ext2 superblocks will need another two patches. By
the time all filesystems are done, it would be thousands of lines if it was
all in one patch. I think it's better to keep it broken up, and do it
incrementally.

--
Daniel