public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: andersg@0x63.nu
Cc: Andrew Morton <akpm@zip.com.au>,
	linux-kernel@vger.kernel.org, lvm-devel@sistina.com
Subject: Re: lvm in 2.5.1
Date: Thu, 27 Dec 2001 16:20:19 +0100	[thread overview]
Message-ID: <20011227162019.C1730@suse.de> (raw)
In-Reply-To: <20011227084304.GA26255@h55p111.delphi.afb.lu.se> <3C2AEADB.24BEFE94@zip.com.au> <20011227122520.GA2194@h55p111.delphi.afb.lu.se> <20011227135453.GA5803@h55p111.delphi.afb.lu.se>
In-Reply-To: <20011227135453.GA5803@h55p111.delphi.afb.lu.se>

On Thu, Dec 27 2001, andersg@0x63.nu wrote:
> -	int rw = bio_data_dir(bh);
> +	int rw = bio_data_dir(bi);
>  
>  
>  	down_read(&lv->lv_lock);
> @@ -1151,7 +1154,7 @@
>  
>  	P_MAP("%s - lvm_map minor: %d  *rdev: %s  *rsector: %lu  size:%lu\n",
>  	      lvm_name, minor,
> -	      kdevname(bh->bi_dev),
> +	      kdevname(bi->bi_dev),
>  	      rsector_org, size);
>  
>  	if (rsector_org + size > lv->lv_size) {
> @@ -1205,7 +1208,7 @@
>  	 * we need to queue this request, because this is in the fast path.
>  	 */
>  	if (rw == WRITE || rw == WRITEA) {
> -		if(_defer_extent(bh, rw, rdev_map,
> +		if(_defer_extent(bi, rw, rdev_map,
>  				 rsector_map, vg_this->pe_size)) {

You are tossing out read-ahead info here, you want to use bio_rw and not
bio_data_dir. The former will pass back xA bits too, while bio_data_dir
is strictly the data direction (strangely :-)

-- 
Jens Axboe


  reply	other threads:[~2001-12-27 15:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-27  8:43 lvm in 2.5.1 andersg
2001-12-27  9:33 ` Andrew Morton
2001-12-27 12:25   ` andersg
2001-12-27 13:54     ` andersg
2001-12-27 15:20       ` Jens Axboe [this message]
2001-12-27 16:02         ` andersg
2001-12-27 16:11           ` Jens Axboe
2001-12-27 17:18           ` [lvm-devel] " Andreas Dilger
2001-12-27 19:25     ` Andrew Morton
2001-12-27 19:37       ` andersg
2001-12-27 19:45         ` Andrew Morton
2001-12-27 20:24           ` andersg
2001-12-28 16:45             ` Jan Niehusmann
2001-12-28 20:17               ` [lvm-devel] " Andreas Dilger
2001-12-28 20:43                 ` andersg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011227162019.C1730@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@zip.com.au \
    --cc=andersg@0x63.nu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvm-devel@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox