Re: [RFC][PATCH] unchecked request_region's in drivers/net

James A Sutherland
2001-12-28T09:49:57Z

On Thursday 27 December 2001 11:40 pm, Dave Jones wrote:
> On Thu, 27 Dec 2001, James A Sutherland wrote:
> > I'd add one level of abstraction: have each filename map to a "module"
> > name. In this case, each filename relating to devfs would map to module
> > "devfs"; there would then be an entry mapping devfs <-> Richard.
> > (Perhaps a hierarchy - fs.devfs - with people like Al listed for "fs"?)
>
> Could work, but there are some bits that have no maintainer as such,
> eg, the pci irq routing. There have been several interested parties
> hacking on it however. A means of having people add themselves to the
> list would be a 'must have' feature.

Yes. Something like mailman's approach, perhaps? (You set a password when you
subscribe, then you can see and change which modules you are subscribed to
using that password.)

> > It should be a little easier having a mapping to a module - in most
> > cases, there's a clear "module" to which each file belongs. Then just
> > track who's "subscribed to" that module...
>
> Having a mapping from kernel source filename -> email address would
> still be preferred personally.

You would still have that feature: my script was intended to take patches,
filenames or modulenames as input, and list the interested parties and/or
module names.

So...

$ cclist -m big_patch
fs/devfs
arch/x86

$ cclist -f fs/devfs/base.c
Richard Gooch <...>
Al Viro <...>

> $ cclist devfs
>
> is really not much of an improvement over
>
> $ grep -C3 -i devfs MAINTAINERS
>
> Other than the addition of extra 'interested, cc me too' people.

And tracking of filename<->module relationships, allowing you to look up who
would be interested in a given patch.

> The only problem with my original idea is that its a pita to keep
> up to date. kernel files get added and removed on a weekly (sometimes
> daily) basis. Whoever is dumb^Wwonderful enough to volunteer to
> maintain such a database is likely to have their work cut out for
> them, so maybe your module idea is preferable.

In the way I'm suggesting, it just simplifies matters a little: rather than
having to list RG and AV separately for every single file in devfs, just say
"this new file is part of devfs" and it "inherits" them that way.

James.