Re: hdc: dma_intr: status=0x51 { DriveReady SeekComplete Error }

Jens Axboe
2001-12-29T15:08:10Z

On Fri, Dec 28 2001, Peter Osterlund wrote:
> Jens Axboe <axboe@suse.de> writes:
>
> > On Fri, Dec 28 2001, Rik van Riel wrote:
> > > On Fri, 28 Dec 2001, Jens Axboe wrote:
> > > >
> > > > Tried reading the source?
> > >
> > > As usual, without documentation you only know what the code
> > > does, not what it's supposed to do or why it does it.
> >
> > please look at the source before making such comments -- it's quite
> > adequately commented.
>
> I agree, but I have one specific question though. What are the
> bi_end_io() functions supposed to return? The return value doesn't
> ever seem to be used (yet?), so reading the source code can not answer
> that question.

They were supposed to return 0 if the bio was completely done, or 1 if
there was remaining I/O to be done. Right now it's unused, so just
return 0 for success.

--
Jens Axboe