From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Daniel Phillips <phillips@bonn-fries.net>,
<linux-kernel@vger.kernel.org>,
Alexander Viro <viro@math.psu.edu>,
<linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] [WIP] Unbork fs.h, 3 of 3
Date: Mon, 31 Dec 2001 17:01:25 -0200 [thread overview]
Message-ID: <20011231170125.B15954@conectiva.com.br> (raw)
In-Reply-To: <E16Kv7J-0003CW-00@starship.berlin> <Pine.LNX.4.33.0112311004580.1404-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.33.0112311004580.1404-100000@penguin.transmeta.com>
Em Mon, Dec 31, 2001 at 10:16:14AM -0800, Linus Torvalds escreveu:
> How about using a descriptor structure instead of the macro, and making
> the filesystem declaration syntax look more like
>
> static struct file_system_type ext2_descriptor = {
> owner: THIS_MODULE,
> fs_flags: FS_REQUIRES_DEV,
> name: "ext2",
> read_super: ext2_read_super,
> sb_size: sizeof(ext2_sb_info),
> inode_size: sizeof(struct ext2_inode_info)
> };
>
> which is more readable, and inherently documents _what_ those things are.
Agreed, this is how the other structs of similar purpose (proto_opts,
net_proto_family, etc) are initialized.
- Arnaldo
next prev parent reply other threads:[~2001-12-31 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-31 5:36 [RFC] [WIP] Unbork fs.h, 3 of 3 Daniel Phillips
2001-12-31 18:16 ` Linus Torvalds
2001-12-31 19:01 ` Arnaldo Carvalho de Melo [this message]
2001-12-31 19:41 ` Daniel Phillips
2002-01-01 3:55 ` David Chow
2002-01-02 11:01 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011231170125.B15954@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox