public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@zip.com.au>,
	Manfred Spraul <manfred@colorfullife.com>,
	Dave Jones <davej@suse.de>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Prefetching file_read_actor()
Date: Tue, 1 Jan 2002 22:08:38 +1100	[thread overview]
Message-ID: <20020101110838.GA11768@krispykreme> (raw)
In-Reply-To: <3C30BC5F.227349E8@zip.com.au> <E16LMBW-0008Dk-00@the-village.bc.nu>
In-Reply-To: <E16LMBW-0008Dk-00@the-village.bc.nu>

 
> Please bury such things in arch/cpu specific routines. Most non intel
> processor hardware isnt that broken.

Exactly, for example ppc32 and ppc64 implement the prefetch macros so we
cant put intel specific prefetch hacks in generic code. 

The correct place to do it is in the copy_*_user routines where you can
make decisions based on length etc. Davem already does this for sparc64
and Paulus is working on it for ppc32/64.

I just grepped around for current prefetch usage and noticed we now
use it in the list macros. Converting non struct list code (eg pagecache
hash) to use for_each_list etc might give some benefits.

Perhaps for_each_task could benefit from the same prefetching.

Anton

  reply	other threads:[~2002-01-01 11:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-31  3:32 [patch] Prefetching file_read_actor() Dave Jones
2001-12-31  5:44 ` Andrew Morton
2001-12-31 10:58   ` Manfred Spraul
2001-12-31 19:28     ` Andrew Morton
2001-12-31 19:47       ` Dave Jones
2001-12-31 20:40         ` Ryan Cumming
2002-01-01 10:29         ` Alan Cox
2002-01-01 12:45           ` Dave Jones
2002-01-01 15:26             ` Alan Cox
2002-01-01 10:30       ` Alan Cox
2002-01-01 11:08         ` Anton Blanchard [this message]
2001-12-31 20:31     ` Dave Jones
2001-12-31 13:00   ` Alan Cox
2001-12-31 12:50 ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020101110838.GA11768@krispykreme \
    --to=anton@samba.org \
    --cc=akpm@zip.com.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox