From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "David S. Miller" <davem@redhat.com>,
SteveW@ACM.org, jschlst@samba.org, ncorbic@sangoma.com,
eis@baty.hanse.de, dag@brattli.net, torvalds@transmeta.com,
marcelo@conectiva.com.br, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: [PATCH][RFC 5] cleaning up struct sock
Date: Wed, 2 Jan 2002 05:00:02 -0200 [thread overview]
Message-ID: <20020102050001.A19285@conectiva.com.br> (raw)
Hi,
This one turns IP_SK and IP6_PINFO usage the style TCP_PINFO and to
some extent IP6_PINFO (and its previous equivalents, sk->tp_pinfo.af_tcp
and sk->net_pinfo.ipv6), i.e., using a local variable to hold the result of
IP_SK/IP6_PINFO/TCP_PINFO and use this variable instead of the ugly
MACRO()->struct_member style. It also fixed a simple error in IP6_PINFO
that was causing oopses on IPv6 connections (it was using the tcp area).
The fs unbork patch by Daniel Phillips also uses the same approach
wrt local variables.
It still doesn't make the IPv6 family protocols use each a private
slabcache, i.e., there's still only one slabcache for all IPv6 protocols,
I'll work on this RSN.
Patch available at:
http://www.kernel.org/pub/linux/kernel/people/acme/v2.5/2.5.2-pre6
sock.cleanup-2.5.2-pre6.bz2
Comments and test results are welcome.
- Arnaldo
reply other threads:[~2002-01-02 7:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020102050001.A19285@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=SteveW@ACM.org \
--cc=dag@brattli.net \
--cc=davem@redhat.com \
--cc=eis@baty.hanse.de \
--cc=jschlst@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=ncorbic@sangoma.com \
--cc=netdev@oss.sgi.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox