From: Oleg Drokin <green@namesys.com>
To: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org,
reiserfs-dev@namesys.com
Subject: [PATCH] tail data corruption on mempressure
Date: Thu, 3 Jan 2002 10:16:56 +0300 [thread overview]
Message-ID: <20020103101656.A2592@namesys.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
Hello!
This patch fixes a bug when mmap-write to a file tail and subsequent read cause written data to be lost
due to page-cache interacting mistake in low number of free buffers situation.
Please apply.
Bye,
Oleg
[-- Attachment #2: tail_data_corruption_on_mempressure-1.diff --]
[-- Type: text/plain, Size: 947 bytes --]
--- linux/fs/reiserfs/inode.c.orig Thu Dec 20 11:07:05 2001
+++ linux/fs/reiserfs/inode.c Thu Dec 20 19:03:51 2001
@@ -325,6 +325,16 @@
*/
if (buffer_uptodate(bh_result)) {
goto finished ;
+ } else
+ /*
+ ** grab_tail_page can trigger calls to reiserfs_get_block on up to date
+ ** pages without any buffers. If the page is up to date, we don't want
+ ** read old data off disk. Set the up to date bit on the buffer instead
+ ** and jump to the end
+ */
+ if (Page_Uptodate(bh_result->b_page)) {
+ mark_buffer_uptodate(bh_result, 1);
+ goto finished ;
}
// read file tail into part of page
@@ -833,7 +843,7 @@
}
if (retval == POSITION_FOUND) {
reiserfs_warning ("vs-825: reiserfs_get_block: "
- "%k should not be found\n", &key);
+ "%K should not be found\n", &key);
retval = -EEXIST;
if (allocated_block_nr)
reiserfs_free_block (&th, allocated_block_nr);
reply other threads:[~2002-01-03 7:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020103101656.A2592@namesys.com \
--to=green@namesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox