From: Oleg Drokin <green@namesys.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org,
reiserfs-dev@namesys.com, viro@math.psu.edu
Subject: Re: [PATCH] expanding truncate
Date: Thu, 3 Jan 2002 15:25:20 +0300 [thread overview]
Message-ID: <20020103152520.A7030@namesys.com> (raw)
In-Reply-To: <20020103102128.A2625@namesys.com> <E16M6wB-00089t-00@the-village.bc.nu>
In-Reply-To: <E16M6wB-00089t-00@the-village.bc.nu>
Hello!
On Thu, Jan 03, 2002 at 12:25:34PM +0000, Alan Cox wrote:
> > This patch makes sure that indirect pointers for holes are correctly filled in by zeroes at
> > hole-creation time. (Author is Chris Mason. fs/buffer.c part (generic_cont_expand) were written by
> > Alexander Viro)
> Why is that even needed. If you truncate a file larger it doesn't need to
> fill in the datablocks until they are touched surely
Purpose of this patch is of course not to fill in the datablocks with zeroes.
The purpose (as applied to reiserfs) is to fill indirect data pointers (that is - pointers to real data blocks)
with zeroes (and to organize proper in-tree data structure for such pointers).
As of now such organization and zero-filling is done on a lazy manner at disk-flushing time.
Unfortunatelly this leads to races in the code.
I do not know why parts of this code can be needed by other filesystem and why Al Viro put it in generic VFS
code. (but he can comment on it, I think)
Bye,
Oleg
next prev parent reply other threads:[~2002-01-03 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-03 7:21 [PATCH] expanding truncate Oleg Drokin
2002-01-03 7:50 ` Andrew Morton
2002-01-03 12:25 ` Alan Cox
2002-01-03 12:25 ` Oleg Drokin [this message]
2002-01-03 16:17 ` Alexander Viro
2002-01-04 17:33 ` [reiserfs-dev] " Chris Mason
2002-01-11 20:52 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020103152520.A7030@namesys.com \
--to=green@namesys.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=reiserfs-dev@namesys.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox