From: Jens Axboe <axboe@suse.de>
To: petter wahlman <petter@bluezone.no>
Cc: linux-kernel@vger.kernel.org, ipslinux@us.ibm.com
Subject: Re: bug in IBM ServeRAID driver?
Date: Thu, 3 Jan 2002 21:06:53 +0100 [thread overview]
Message-ID: <20020103210653.H8673@suse.de> (raw)
In-Reply-To: <1010087472.9561.0.camel@BadEip>
In-Reply-To: <1010087472.9561.0.camel@BadEip>
On Thu, Jan 03 2002, petter wahlman wrote:
>
> While looking through linux-2.4.18pre1/drivers/scsi/ips.c I noticed that
> a spin_lock_irq is held while doing a possibly blocking operation.
> Can't this code livelock on SMP if datasize is set?
>
> linux-2.4.18pre1/drivers/scsi/ips.c
>
> 1778 /* reobtain the lock */
> 1779 spin_lock_irq(&io_request_lock);
> 1780
> 1781 /* command finished -- copy back */
> 1782 user_area = *((char **) &SC->cmnd[4]);
> 1783 kern_area = ha->ioctl_data;
> 1784 datasize = *((u_int32_t *) &SC->cmnd[8]);
> 1785
> 1786 if (datasize) {
> 1787 if (copy_to_user(user_area, kern_area, datasize) > 0) {
> 1788 DEBUG_VAR(1, "(%s%d) passthru failed - unable to
> copy out user data",
> 1789 ips_name, ha->host_num);
>
>
> I am not subscribed to this list, so please CC me.
Yup, that's surely a nasty bug.
--
Jens Axboe
next prev parent reply other threads:[~2002-01-03 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-03 19:51 bug in IBM ServeRAID driver? petter wahlman
2002-01-03 20:06 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-01-07 13:02 ServeRAID For Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020103210653.H8673@suse.de \
--to=axboe@suse.de \
--cc=ipslinux@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=petter@bluezone.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox