From: "J.A. Magallon" <jamagallon@able.es>
To: Daniel Phillips <phillips@bonn-fries.net>
Cc: Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
Ion Badulescu <ion@cs.columbia.edu>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [CFT] [JANITORIAL] Unbork fs.h
Date: Fri, 4 Jan 2002 00:25:53 +0100 [thread overview]
Message-ID: <20020104002553.A15792@werewolf.able.es> (raw)
In-Reply-To: <200201031605.g03G57e22947@guppy.limebrokerage.com> <E16MAp4-00018b-00@starship.berlin> <20020103143630.D25846@conectiva.com.br> <E16MBIw-00018y-00@starship.berlin>
In-Reply-To: <E16MBIw-00018y-00@starship.berlin>; from phillips@bonn-fries.net on Thu, Jan 03, 2002 at 18:05:19 +0100
On 20020103 Daniel Phillips wrote:
>>
>> Maybe CodingStyle should have an entry for this, I'd vote for this style:
>>
>> static inline struct inode *new_inode(struct super_block *sb)
>
>OK, I'll revise it to that style. Shall we start an official janitor's style
>guide? ;-)
>
Perhaps it is a silly question for kernel hackers, but I found it useful
for making code more readable...
Why dont you use things like:
typedef struct inode inode;
typedef struct super_block super_block;
so you can write things like
static inline inode* new_inode(super_block* cb)
{
inode* ni;
ni = (inode*)malloc(sizeof(inode));
...
}
(ie, kill 'struct' visual pollution...)
??
Isn't it more readable ?
Just curious...
--
J.A. Magallon # Let the source be with you...
mailto:jamagallon@able.es
Mandrake Linux release 8.2 (Cooker) for i586
Linux werewolf 2.4.18-pre1-beo #3 SMP Thu Dec 27 10:15:27 CET 2001 i686
next prev parent reply other threads:[~2002-01-03 23:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-03 12:47 [CFT] [JANITORIAL] Unbork fs.h Daniel Phillips
2002-01-03 14:03 ` Daniel Phillips
2002-01-03 15:45 ` Christoph Hellwig
2002-01-03 16:20 ` Daniel Phillips
2002-01-03 16:47 ` Alexander Viro
2002-01-03 17:25 ` Daniel Phillips
2002-01-03 18:25 ` Daniel Phillips
2002-01-03 18:35 ` Christoph Hellwig
2002-01-03 16:45 ` Alexander Viro
2002-01-03 18:04 ` Daniel Phillips
2002-01-03 16:05 ` Ion Badulescu
2002-01-03 16:34 ` Daniel Phillips
2002-01-03 16:28 ` Martin Dalecki
2002-01-03 16:45 ` Arnaldo Carvalho de Melo
2002-01-03 16:36 ` Arnaldo Carvalho de Melo
2002-01-03 17:05 ` Daniel Phillips
2002-01-03 17:07 ` Arnaldo Carvalho de Melo
2002-01-03 19:36 ` Andreas Dilger
2002-01-04 7:05 ` Daniel Phillips
2002-01-04 8:59 ` Andreas Dilger
2002-01-04 10:02 ` Jeff Garzik
2002-01-03 23:25 ` J.A. Magallon [this message]
2002-01-04 1:44 ` Daniel Phillips
2002-01-04 14:52 ` J.A. Magallon
2002-01-03 18:53 ` Daniel Phillips
2002-01-03 20:31 ` Ion Badulescu
-- strict thread matches above, loose matches on Subject: below --
2002-01-04 15:16 Andries.Brouwer
2002-01-04 22:20 ` Andreas Dilger
2002-01-04 23:33 ` Daniel Phillips
2002-01-04 16:45 Bryan Henderson
2002-01-04 22:15 ` Andreas Dilger
2002-01-05 1:07 Bryan Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020104002553.A15792@werewolf.able.es \
--to=jamagallon@able.es \
--cc=acme@conectiva.com.br \
--cc=ion@cs.columbia.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox