public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan <alan@clueserver.org>
To: linux-kernel@vger.kernel.org
Cc: mec@shout.net, alan@redhat.com, Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@transmeta.com>
Subject: [PATCH] USB Storage Config patch for 2.4.17 and 2.5.1
Date: Fri, 4 Jan 2002 00:11:58 -0800	[thread overview]
Message-ID: <200201041041.g04AfiL05830@clueserver.org> (raw)

This is a pretty trivial patch, but it fixes something kind of annoying.

USB Storage does not show up in the config menu if SCSI is not enabled.

My laptop is the only place i ever use USB.  I would always disable SCSI 
because I don't have any SCSI devices for my laptop.  

Then I tried to figure out why my USB floppy drive would never work...

The following patch modifies the config to display a "You need to enable SCSI 
for USB Storage" message if SCSI is not enabled.  (Using the exact phrasing 
(and code) from the USB multimedia message.)

Here is the patch. It has been tested for 2.4.17 and 2.5.1.  It would have 
been shorter, but i added indenting to make the code look consistant.) 
Hopefully linewrap does not hose this.

--------------- use boxknife on monitor here------------------
--- drivers/usb/Config.in	Fri Nov  2 17:18:58 2001
+++ drivers/usb/Config.in	Fri Jan  4 03:29:49 2002
@@ -32,15 +32,19 @@
 comment 'USB Device Class drivers'
 dep_tristate '  USB Audio support' CONFIG_USB_AUDIO $CONFIG_USB $CONFIG_SOUND
 dep_tristate '  USB Bluetooth support (EXPERIMENTAL)' CONFIG_USB_BLUETOOTH 
$CONFIG_USB $CONFIG_EXPERIMENTAL
-dep_tristate '  USB Mass Storage support' CONFIG_USB_STORAGE $CONFIG_USB 
$CONFIG_SCSI
-   dep_mbool '    USB Mass Storage verbose debug' CONFIG_USB_STORAGE_DEBUG 
$CONFIG_USB_STORAGE
-   dep_mbool '    Datafab MDCFE-B Compact Flash Reader support' 
CONFIG_USB_STORAGE_DATAFAB $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
-   dep_mbool '    Freecom USB/ATAPI Bridge support' 
CONFIG_USB_STORAGE_FREECOM  $CONFIG_USB_STORAGE
-   dep_mbool '    ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200 
$CONFIG_USB_STORAGE
-   dep_mbool '    Microtech CompactFlash/SmartMedia support' 
CONFIG_USB_STORAGE_DPCM $CONFIG_USB_STORAGE
-   dep_mbool '    HP CD-Writer 82xx support' CONFIG_USB_STORAGE_HP8200e 
$CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
-   dep_mbool '    SanDisk SDDR-09 (and other SmartMedia) support' 
CONFIG_USB_STORAGE_SDDR09 $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
-   dep_mbool '    Lexar Jumpshot Compact Flash Reader' 
CONFIG_USB_STORAGE_JUMPSHOT $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
+if [ "$CONFIG_SCSI" = "n" ]; then
+   comment '  SCSI support is needed for USB Storage'
+else
+   dep_tristate '  USB Mass Storage support' CONFIG_USB_STORAGE $CONFIG_USB 
$CONFIG_SCSI
+      dep_mbool '    USB Mass Storage verbose debug' 
CONFIG_USB_STORAGE_DEBUG $CONFIG_USB_STORAGE
+      dep_mbool '    Datafab MDCFE-B Compact Flash Reader support' 
CONFIG_USB_STORAGE_DATAFAB $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
+      dep_mbool '    Freecom USB/ATAPI Bridge support' 
CONFIG_USB_STORAGE_FREECOM  $CONFIG_USB_STORAGE
+      dep_mbool '    ISD-200 USB/ATA Bridge support' 
CONFIG_USB_STORAGE_ISD200 $CONFIG_USB_STORAGE
+      dep_mbool '    Microtech CompactFlash/SmartMedia support' 
CONFIG_USB_STORAGE_DPCM $CONFIG_USB_STORAGE
+      dep_mbool '    HP CD-Writer 82xx support' CONFIG_USB_STORAGE_HP8200e 
$CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
+      dep_mbool '    SanDisk SDDR-09 (and other SmartMedia) support' 
CONFIG_USB_STORAGE_SDDR09 $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
+      dep_mbool '    Lexar Jumpshot Compact Flash Reader' 
CONFIG_USB_STORAGE_JUMPSHOT $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
+fi
 dep_tristate '  USB Modem (CDC ACM) support' CONFIG_USB_ACM $CONFIG_USB
 dep_tristate '  USB Printer support' CONFIG_USB_PRINTER $CONFIG_USB
 

             reply	other threads:[~2002-01-04  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-04  8:11 Alan [this message]
2002-01-04 17:17 ` [PATCH] USB Storage Config patch for 2.4.17 and 2.5.1 Greg KH
2002-01-04 18:47   ` Alan
2002-01-04 21:48     ` Greg KH
2002-01-04 20:49       ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200201041041.g04AfiL05830@clueserver.org \
    --to=alan@clueserver.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mec@shout.net \
    --cc=mingo@elte.hu \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox