From: Andreas Dilger <adilger@turbolabs.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Daniel Phillips <phillips@bonn-fries.net>,
Linux-Kernel list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>,
viro@math.psu.edu
Subject: Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)
Date: Mon, 7 Jan 2002 17:15:00 -0700 [thread overview]
Message-ID: <20020107171500.L777@lynx.no> (raw)
In-Reply-To: <20020107132121.241311F6A@gtf.org> <E16NbYF-0001Qq-00@starship.berlin> <3C3A33E2.D297F570@mandrakesoft.com>
In-Reply-To: <3C3A33E2.D297F570@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Mon, Jan 07, 2002 at 06:48:50PM -0500
On Jan 07, 2002 18:48 -0500, Jeff Garzik wrote:
> Daniel Phillips wrote:
> > Moving the ext2 headers from include/linux to fs/ext2 is an interesting
> > feature of your patch, though it isn't essential to the idea you're
> > presenting. But is there a good reason why ext2_fs_i.h and ext2_fs_sb.h
> > should remain separate from ext2_fs.h? It looks like gratuitous
> > modularity to me.
>
> apparently userspace includes them, which is the reason for the strange
> types. good reason to continue to keep them separate. That's also why
> my patch7 adds an ifdef __KERNEL__.
Could you be more specific? AFAIK, the ext2_fs.h file is also used by
e2fsprogs (which actually has its own, _more_ up-to-date version of this
file), but the _i.h and _sb.h files are for kernel use only. They do not
have any relation to on-disk ext2 structs, so there would not really be
any point in referencing them from userspace.
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/
next prev parent reply other threads:[~2002-01-08 0:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-07 13:21 PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7) Jeff Garzik
2002-01-07 14:13 ` Anton Altaparmakov
2002-01-07 15:33 ` Daniel Phillips
2002-01-07 21:27 ` Jeff Garzik
2002-01-08 6:32 ` Daniel Phillips
2002-01-08 6:31 ` Jeff Garzik
2002-01-08 6:38 ` Daniel Phillips
2002-01-07 16:01 ` Anton Altaparmakov
2002-01-07 16:23 ` Daniel Phillips
2002-01-07 17:25 ` Mark Zealey
2002-01-07 15:19 ` Daniel Phillips
2002-01-07 20:54 ` Juan Quintela
2002-01-08 4:10 ` Daniel Phillips
2002-01-07 21:25 ` Jeff Garzik
2002-01-08 3:06 ` Daniel Phillips
2002-01-07 23:48 ` Jeff Garzik
2002-01-08 0:15 ` Andreas Dilger [this message]
2002-01-08 0:17 ` Jeff Garzik
2002-01-08 3:28 ` Daniel Phillips
2002-01-07 16:10 ` Daniel Phillips
2002-01-07 19:38 ` Alexander Viro
2002-01-07 21:37 ` Jeff Garzik
2002-01-07 23:28 ` [PATCH 7/7 v2] " Jeff Garzik
2002-01-07 23:49 ` [Ext2-devel] " Andreas Dilger
2002-01-07 23:52 ` Jeff Garzik
2002-01-07 21:32 ` Jeff Garzik
2002-01-07 21:49 ` Arnaldo Carvalho de Melo
2002-01-07 21:58 ` Jeff Garzik
2002-01-07 23:46 ` Jeff Garzik
2002-01-08 0:17 ` [Ext2-devel] " Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020107171500.L777@lynx.no \
--to=adilger@turbolabs.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox