public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: bounce buffer usage
Date: Tue, 8 Jan 2002 08:42:00 +0100	[thread overview]
Message-ID: <20020108084200.B19380@suse.de> (raw)
In-Reply-To: <20011223150940.E7438@suse.de> <Pine.LNX.4.33L2.0201071740350.7535-100000@dragon.pdx.osdl.net>
In-Reply-To: <Pine.LNX.4.33L2.0201071740350.7535-100000@dragon.pdx.osdl.net>

On Mon, Jan 07 2002, Randy.Dunlap wrote:
> On Sun, 23 Dec 2001, Jens Axboe wrote:
> 
> | On Fri, Dec 21 2001, Randy.Dunlap wrote:
> | > Are there any drivers in 2.4.x that support highmem directly,
> | > or is all of that being done in 2.5.x (BIO patches)?
> |
> | 2.4 + my block-highmem patches support direct highmem I/O.
> |
> | > Would it be useful to try this with a 2.5.1 kernel?
> |
> | Sure
> 
> 
> OK, here's 'fillmem 700' run against 5 kernels as described below,
> with my bounce io/swap statistics patch added.
> 
> All tests are 6 instances of "fillmem 700" (700 MB) on a 4-way 4 GB
> x86 VA 4450 server.
> 
> I'm including a reduced version of /proc/stat -- before and after the
> fillmem test in each case.
> 
> Let me know if you'd like to see other variations.

The results look very promising, although I'm a bit surprised that 2.5
is actually that much quicker :-)

The bounce counts you are doing don't make too much sense to me though,
how come 2.4 + block-high and 2.5 show any bounced numbers at all? Maybe
you are not doing the accounting correctly? To get the right counts do
something ala:

+++ mm/highmem.c
@@ -409,7 +409,9 @@
                        vfrom = kmap(from->bv_page) + from->bv_offset;
                        memcpy(vto, vfrom, to->bv_len);
                        kunmap(from->bv_page);
-               }
+                       bounced_write++;
+               } else
+                       bounced_read++;
        }

Of course those are all bounces, not just (or only) swap bounces. Also
note that the above is not SMP safe.

-- 
Jens Axboe


  reply	other threads:[~2002-01-08  7:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-22  1:02 bounce buffer usage Randy.Dunlap
2001-12-23 14:09 ` Jens Axboe
2002-01-08  1:44   ` Randy.Dunlap
2002-01-08  7:42     ` Jens Axboe [this message]
2002-01-09 17:23       ` Randy.Dunlap
2002-01-09 18:10         ` Jens Axboe
2002-01-09 22:33         ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020108084200.B19380@suse.de \
    --to=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox