From: Roger Larsson <roger.larsson@norran.net>
To: Andrew Morton <akpm@zip.com.au>, Christoph Hellwig <hch@caldera.de>
Cc: Robert Love <rml@tech9.net>, David Howells <dhowells@redhat.com>,
torvalds@transmeta.com, arjanv@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] preempt abstraction
Date: Tue, 8 Jan 2002 22:25:20 +0100 [thread overview]
Message-ID: <200201082128.g08LS0Z08702@maila.telia.com> (raw)
In-Reply-To: <10940.1010511619@warthog.cambridge.redhat.com> <20020108195920.A14642@caldera.de> <3C3B5C02.9929B8@zip.com.au>
In-Reply-To: <3C3B5C02.9929B8@zip.com.au>
On Tuesday den 8 January 2002 21.52, Andrew Morton wrote:
> Christoph Hellwig wrote:
> > On Tue, Jan 08, 2002 at 01:57:28PM -0500, Robert Love wrote:
> > > Why not use the more commonly named conditional_schedule instead of
> > > preempt() ? In addition to being more in-use (low-latency, lock-break,
> > > and Andrea's aa patch all use it) I think it better conveys its
> > > meaning, which is a schedule() but only conditionally.
> >
> > I think the choice is very subjective, but I prefer preempt().
> > It's nicely short to type (!) and similar in spirit to Ingo's yield()..
>
> naah. preempt() means preempt. But the implementation
> is in fact maybe_preempt(), or preempt_if_needed().
>
how about
preemption_point();
A point of (possible) preemption...
It might be nice to add the orthogonal
preempt_disable()
preemtion_enable()
At the same time - see Robert Loves patch for places.
(mostly around CPU specific data)
But they should be null statements for now...
/RogerL
--
Roger Larsson
Skellefteå
Sweden
next prev parent reply other threads:[~2002-01-08 21:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-08 17:40 [PATCH] preempt abstraction David Howells
2002-01-08 18:13 ` Jeff Garzik
2002-01-08 18:57 ` Robert Love
2002-01-08 18:59 ` Christoph Hellwig
2002-01-08 20:52 ` Andrew Morton
2002-01-08 21:25 ` Roger Larsson [this message]
2002-01-08 22:12 ` Daniel Phillips
2002-01-08 22:35 ` David Howells
2002-01-08 22:46 ` David Howells
2002-01-08 23:05 ` Robert Love
2002-01-08 21:30 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200201082128.g08LS0Z08702@maila.telia.com \
--to=roger.larsson@norran.net \
--cc=akpm@zip.com.au \
--cc=arjanv@redhat.com \
--cc=dhowells@redhat.com \
--cc=hch@caldera.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox