From: Jens Axboe <axboe@suse.de>
To: Douglas Gilbert <dougg@torque.net>
Cc: admin@nextframe.net, torvalds@transmeta.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/psi240i.c - io_request_lock fix
Date: Wed, 9 Jan 2002 11:46:38 +0100 [thread overview]
Message-ID: <20020109114638.S19814@suse.de> (raw)
In-Reply-To: <20020108150738.B6168@sexything> <3C3B9853.740E71DA@torque.net>
In-Reply-To: <3C3B9853.740E71DA@torque.net>
On Tue, Jan 08 2002, Douglas Gilbert wrote:
> Morten Helgesen wrote:
> >
> > Hey Linus and the rest of you.
> >
> > A simple fix for the io_request_lock issue leftovers in drivers/scsi/psi240i.c.
> > Not tested, but compiles. Diffed against 2.5.2-pre10. Please apply.
> >
>
> Morten,
> There is a bit more involved than just switching
> io_request_lock to host_lock. The former is global
> so it could be called from anywhere.
>
> >From the look of this line in the patch:
> > + struct Scsi_Host *host = PsiHost[irq - 10];
>
> It will work if the first controller is allocated irq 10,
> the second one irq 11, etc. Unlikely ...
Irk yes, that is very ugly! And it's even used currently in the driver
as well. How about passing the scsi host as device_id for the isr
instead?
--
Jens Axboe
next prev parent reply other threads:[~2002-01-09 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-08 14:07 [PATCH] drivers/scsi/psi240i.c - io_request_lock fix Morten Helgesen
2002-01-09 1:09 ` Douglas Gilbert
2002-01-09 10:46 ` Jens Axboe [this message]
2002-01-09 11:07 ` Morten Helgesen
-- strict thread matches above, loose matches on Subject: below --
2002-01-09 13:28 Adam J. Richter
2002-01-09 13:52 ` Morten Helgesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020109114638.S19814@suse.de \
--to=axboe@suse.de \
--cc=admin@nextframe.net \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox