Re: [PATCH] PAGE_SIZE IO for RAW (RAW VARY)

Andrea Arcangeli
2002-01-11T13:54:04Z

On Thu, Jan 10, 2002 at 08:58:41AM -0800, Badari Pulavarty wrote:
> Andrea,
>
> > >
> > > I still wouldn't feel to good doing this, and just because snapshotting
> > > opens the possibility for this to happen doesn't mean it a) ever
> > > triggered in real life, and b) works on all devices.
> >
> > fair enough. one way to do it certainly safely is to add a bitflag to
> > the struct blkkdev.
> >
> > Andrea
> >
>
> Could you please elaborate on your suggestion. What does a biflag in
> blkdev do ?
>
> I am sure by now, you must have understood what my patch is trying to
> do. I am trying to issue 4K buffer heads on RAW whenever possible
> (instead of 512). But for the first and last pages buffer heads may
> be different size than 4K (due to alignment and length of IO). So, We
> end up with buffer heads with multiple IO sizes in a single request.
>
> How does your suggestion fix the problem ? How can I address this
> problem safely. Please let me know.

the bitflag will allow you to enable this feature only on the lowlevel
drivers that you can afford to test. on the hardware that you can afford
to test you will know for sure that enabling the feature is safe. This
way we won't risk random breakage of not-tested drivers.

Andrea