From: Morten Helgesen <admin@nextframe.net>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: axboe@suse.de, dougg@torque.net, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/psi240i.c - io_request_lock fix
Date: Wed, 9 Jan 2002 14:52:24 +0100 [thread overview]
Message-ID: <20020109145224.B7291@sexything> (raw)
In-Reply-To: <200201091328.FAA07632@adam.yggdrasil.com>
In-Reply-To: <200201091328.FAA07632@adam.yggdrasil.com>
On Wed, Jan 09, 2002 at 05:28:00AM -0800, Adam J. Richter wrote:
> >> = Morten Helgesen
> > = Douglas Gilbert
>
> >From the look of this line in the patch:
> >> + struct Scsi_Host *host = PsiHost[irq - 10];
> >
> >It will work if the first controller is allocated irq 10,
> >the second one irq 11, etc. Unlikely ...
>
> No, I think Morten has the use of PsiHost right. The
> entries in PsiHost are apparently stored by IRQ. It is not generally
> the case that the first controller is at PsiHost[0], the second at
> PsiHost[1], etc.
Even though I am not _that_ familiar with the code in question, that is how I
understood it too.
>
> I agree with Jens in that the practice is rather ugly, but that
> is the way the driver worked before io_request_lock disappeared and
> I think that improving that stylistic issue is not a prerequisite
> for conversion from io_request_lock to host->host_lock.
Ugly it is. It was not my intention to clean up the code, just make the smallest change
necessary to get it to work. The maintainer should probably do a closer examination.
>
> If I were you, Morten, I would go ahead with your patch
> that makes the minimal changes and then, if you want, make stylistic
> improvements as one or more separate patches, which are something
> that you may want to talk over with the mainter of that driver, if
> there currently is one.
Sure - but who is the maintainer ? :)
>
> Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
> adam@yggdrasil.com \ / San Jose, California 95129-1034
> +1 408 261-6630 | g g d r a s i l United States of America
> fax +1 408 261-6631 "Free Software For The Rest Of Us."
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
"Det er ikke lett å være menneske" - sitat fra en klok person.
mvh
Morten Helgesen
UNIX System Administrator & C Developer
Nextframe AS
admin@nextframe.net / 93445641
http://www.nextframe.net
next prev parent reply other threads:[~2002-01-09 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 13:28 [PATCH] drivers/scsi/psi240i.c - io_request_lock fix Adam J. Richter
2002-01-09 13:52 ` Morten Helgesen [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-01-08 14:07 Morten Helgesen
2002-01-09 1:09 ` Douglas Gilbert
2002-01-09 10:46 ` Jens Axboe
2002-01-09 11:07 ` Morten Helgesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020109145224.B7291@sexything \
--to=admin@nextframe.net \
--cc=adam@yggdrasil.com \
--cc=axboe@suse.de \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox