From: Greg KH <greg@kroah.com>
To: Vladimir Kondratiev <vladimir.kondratiev@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: __FUNCTION__ - patch for USB
Date: Wed, 9 Jan 2002 14:26:57 -0800 [thread overview]
Message-ID: <20020109222657.GA23143@kroah.com> (raw)
In-Reply-To: <3C3CC04D.2080807@intel.com>
In-Reply-To: <3C3CC04D.2080807@intel.com>
On Thu, Jan 10, 2002 at 12:12:29AM +0200, Vladimir Kondratiev wrote:
> Hello,
> Since I have started this thread, I feel I have to do something real.
> Dummy technical work, but someone have to do it, right?
> I patched USB subsystem, it uses __FUNCTION__ in deprecated way no more.
> What is changed?
> - in usb.h, I modified dbg(), warn(), err(), info() macros to contain
> function name in the prefix. These macros are for simple one-line messages.
> - in all files under drivers/usb, all macros mentioned fixed.
> - all __FUNCTION__ occurencies in drivers/usb revised.
>
> I compiled kednel with all USB modules enabled. Since everything
> compiles OK and all changes are in message formats, this patch should
> not corrupt anything. In the worst case you will get badly formatted
> message.
Your patch makes whitespace changes to a lot of dbg() statements, but
does not modify their contents. Can you please change this, as this
change does not need to happen.
> Patch is against 2.4.17
2.4.18-pre2 has a _lot_ of usb changes and this patch misses a number of
places.
I'd also like to see this against the 2.5.x tree first, as the
recommended compiler for the 2.4.x tree is still 2.95.3, and I don't
think that will change anytime soon.
thanks,
greg k-h
next prev parent reply other threads:[~2002-01-09 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 22:12 __FUNCTION__ - patch for USB Vladimir Kondratiev
2002-01-09 22:26 ` Greg KH [this message]
2002-01-10 10:52 ` Vladimir Kondratiev
2002-01-10 16:09 ` Greg KH
2002-01-11 12:23 ` Vladimir Kondratiev
2002-01-10 9:08 ` Nick Craig-Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020109222657.GA23143@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vladimir.kondratiev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox