From: "David S. Miller" <davem@redhat.com>
To: acme@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] s/TCP_ESTABLISHED/PROTO_ESTABLISHED/g
Date: Thu, 10 Jan 2002 08:21:41 -0800 (PST) [thread overview]
Message-ID: <20020110.082141.74749837.davem@redhat.com> (raw)
In-Reply-To: <20020110161629.GF1010@conectiva.com.br>
In-Reply-To: <20020110161629.GF1010@conectiva.com.br>
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Date: Thu, 10 Jan 2002 14:16:29 -0200
Part of the sock cleanup made me remove the #include <linux/tcp.h> from
include/linux/ip.h and from include/net/sock.h, i.e., it is not needed in
those headers, but then I had to go to udp.c, ipx.c, decnet, etc, and add a
#include <linux/tcp.h> because it needs TCP_ESTABLISHED, TCP_CLOSE, etc,
this is a pet peeve to me, as a janitor :-) Can I change this to
PROTO_ESTABLISHED, PROTO_CLOSE, etc, and have it on a different header, say
include/net/protocol.h? Its strange to have IPX, DecNET, etc having to
include net/tcp.h (that in turn includes ip.h, etc).
If this is ok I can bundle it in the sock cleanup or send it
separately, your call.
These other protocols are just borrowing state machine states from
TCP. I really see no reason to rename them, because then if you did
the TCP usage wouldn't make look right anymore. :-)
I don't mind moving the header include from sock.h to the protocols
though.
Franks a lot,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2002-01-10 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-10 16:16 [RFC] s/TCP_ESTABLISHED/PROTO_ESTABLISHED/g Arnaldo Carvalho de Melo
2002-01-10 16:21 ` David S. Miller [this message]
2002-01-10 17:06 ` Arnaldo Carvalho de Melo
2002-01-10 17:07 ` David S. Miller
2002-01-10 17:13 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020110.082141.74749837.davem@redhat.com \
--to=davem@redhat.com \
--cc=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox