* bad patch in aic7xxx_linux.c
@ 2002-01-09 9:06 Nathan Myers
2002-01-09 9:20 ` David S. Miller
2002-01-09 16:22 ` Marcelo Tosatti
0 siblings, 2 replies; 6+ messages in thread
From: Nathan Myers @ 2002-01-09 9:06 UTC (permalink / raw)
To: marcelo; +Cc: linux-kernel, deischen
Marcelo,
In patch-2.4.17-pre2, a nonsensical change was made in
linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
harmless, it suggests to me that you had intended to fold in an
entirely different patch, and "missed".
I don't find a current maintainer for aic7xxx listed in MAINTAINERS.
Nathan Myers
ncm at cantrip dot org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bad patch in aic7xxx_linux.c
2002-01-09 9:06 bad patch in aic7xxx_linux.c Nathan Myers
@ 2002-01-09 9:20 ` David S. Miller
2002-01-10 7:42 ` Nathan Myers
2002-01-09 16:22 ` Marcelo Tosatti
1 sibling, 1 reply; 6+ messages in thread
From: David S. Miller @ 2002-01-09 9:20 UTC (permalink / raw)
To: ncm-nospam; +Cc: marcelo, linux-kernel, deischen
From: Nathan Myers <ncm-nospam@cantrip.org>
Date: Wed, 9 Jan 2002 09:06:28 +0000
In patch-2.4.17-pre2, a nonsensical change was made in
linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
harmless, it suggests to me that you had intended to fold in an
entirely different patch, and "missed".
Missed? That patch fixes a lethal bug.
I don't find a current maintainer for aic7xxx listed in MAINTAINERS.
It's listed in the aic7xxx sources, but the fix in question came to
Marcelo via Jens Axboe.
Franks a lot,
David S. Miller
davem@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bad patch in aic7xxx_linux.c
2002-01-09 9:20 ` David S. Miller
@ 2002-01-10 7:42 ` Nathan Myers
2002-01-10 17:59 ` Justin T. Gibbs
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Myers @ 2002-01-10 7:42 UTC (permalink / raw)
To: linux-kernel; +Cc: axboe, davem
On Wed, Jan 09, 2002 at 01:20:46AM -0800, David S. Miller wrote:
> From: Nathan Myers <ncm-nospam@cantrip.org>
>> In patch-2.4.18-pre2, a nonsensical change was made in
>> linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
>> harmless, it suggests to me that you had intended to fold in an
>> entirely different patch, and "missed".
>
> Missed? That patch fixes a lethal bug.
Indeed, I missed that the value was also passed to ahc_linux_map_seg()
before being clobbered in the next statement.
> I don't find a current maintainer for aic7xxx listed in MAINTAINERS.
>
> It's listed in the aic7xxx sources, but the fix in question came to
> Marcelo via Jens Axboe.
One can guess, but there are no addresses for anyone noted there later
than 1999. In particular, Justin's address isn't listed.
I am interested in hotplugged aic7xxx (1480 CardBus). I will be posting
an Oops shortly related to that, unless somebody tells me not to bother.
Nathan Myers
ncm at cantrip dot org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bad patch in aic7xxx_linux.c
2002-01-10 7:42 ` Nathan Myers
@ 2002-01-10 17:59 ` Justin T. Gibbs
2002-01-11 2:24 ` David S. Miller
0 siblings, 1 reply; 6+ messages in thread
From: Justin T. Gibbs @ 2002-01-10 17:59 UTC (permalink / raw)
To: Nathan Myers; +Cc: linux-kernel, axboe, davem
>One can guess, but there are no addresses for anyone noted there later
>than 1999. In particular, Justin's address isn't listed.
I monitor this list. A Yahoo search using my name provides several
hits for my email address.
>I am interested in hotplugged aic7xxx (1480 CardBus). I will be posting
>an Oops shortly related to that, unless somebody tells me not to bother.
Feel free to send me the oops.
--
Justin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bad patch in aic7xxx_linux.c
2002-01-10 17:59 ` Justin T. Gibbs
@ 2002-01-11 2:24 ` David S. Miller
0 siblings, 0 replies; 6+ messages in thread
From: David S. Miller @ 2002-01-11 2:24 UTC (permalink / raw)
To: gibbs; +Cc: ncm-nospam, linux-kernel, axboe
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
Date: Thu, 10 Jan 2002 10:59:16 -0700
>One can guess, but there are no addresses for anyone noted there later
>than 1999. In particular, Justin's address isn't listed.
I monitor this list. A Yahoo search using my name provides several
hits for my email address.
Your contact information really ought to be up to date in
the sources and linux/MAINTAINERS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bad patch in aic7xxx_linux.c
2002-01-09 9:06 bad patch in aic7xxx_linux.c Nathan Myers
2002-01-09 9:20 ` David S. Miller
@ 2002-01-09 16:22 ` Marcelo Tosatti
1 sibling, 0 replies; 6+ messages in thread
From: Marcelo Tosatti @ 2002-01-09 16:22 UTC (permalink / raw)
To: Nathan Myers; +Cc: linux-kernel, deischen
On Wed, 9 Jan 2002, Nathan Myers wrote:
> Marcelo,
>
> In patch-2.4.17-pre2, a nonsensical change was made in
> linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
> harmless, it suggests to me that you had intended to fold in an
> entirely different patch, and "missed".
>
> I don't find a current maintainer for aic7xxx listed in MAINTAINERS.
Its not nonsensical: It fixes a critical bug as David pointed out.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-01-11 2:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-01-09 9:06 bad patch in aic7xxx_linux.c Nathan Myers
2002-01-09 9:20 ` David S. Miller
2002-01-10 7:42 ` Nathan Myers
2002-01-10 17:59 ` Justin T. Gibbs
2002-01-11 2:24 ` David S. Miller
2002-01-09 16:22 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox