From: Jens Axboe <axboe@suse.de>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: Badari Pulavarty <pbadari@us.ibm.com>,
linux-kernel@vger.kernel.org, marcelo@conectiva.com.br,
andrea@suse.de
Subject: Re: [PATCH] PAGE_SIZE IO for RAW (RAW VARY)
Date: Thu, 10 Jan 2002 08:12:52 +0100 [thread overview]
Message-ID: <20020110081252.P19814@suse.de> (raw)
In-Reply-To: <20020109125845.B12609@redhat.com> <200201091812.g09ICBF18477@eng2.beaverton.ibm.com> <20020109132148.C12609@redhat.com>
In-Reply-To: <20020109132148.C12609@redhat.com>
On Wed, Jan 09 2002, Benjamin LaHaise wrote:
> On Wed, Jan 09, 2002 at 10:12:11AM -0800, Badari Pulavarty wrote:
> > why ? could you explain ? I am not expecting that user buffer be aligned
> > to PAGE_SIZE.
>
> Okay, that part I misread from the message, but that leaves the question of
> "does it work?" Iirc, Jeff Merkey tested variable sized ios with nwfs, but
> found that triggered bugs in the low level drivers, some of which assume that
> all buffer heads within a request have the same block size. Given that
> concern, I really don't think this is a safe 2.4 patch.
I don't think that point was ever proven, and Jeff never showed any
information as to what was broken. I'm reluctant to allow differently
sized buffers heads in the _same_ request for 2.4 just to be cautios,
but that's a two-liner (or so) in the elevator to stop that from
happening.
--
Jens Axboe
next prev parent reply other threads:[~2002-01-10 7:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 17:41 [PATCH] PAGE_SIZE IO for RAW (RAW VARY) Badari Pulavarty
2002-01-09 17:58 ` Benjamin LaHaise
2002-01-09 18:12 ` Badari Pulavarty
2002-01-09 18:21 ` Benjamin LaHaise
2002-01-09 19:28 ` Badari Pulavarty
2002-01-09 19:49 ` Benjamin LaHaise
2002-01-09 22:58 ` Alan Cox
2002-01-09 23:48 ` Badari Pulavarty
2002-01-10 10:34 ` Andrea Arcangeli
2002-01-10 10:29 ` Andrea Arcangeli
2002-01-10 10:18 ` Andrea Arcangeli
2002-01-10 10:22 ` Jens Axboe
2002-01-10 10:47 ` Andrea Arcangeli
2002-01-10 10:51 ` Jens Axboe
2002-01-10 11:09 ` Andrea Arcangeli
2002-01-10 16:58 ` Badari Pulavarty
2002-01-11 13:52 ` Andrea Arcangeli
2002-01-10 19:24 ` Badari Pulavarty
2002-01-10 20:00 ` Alan Cox
2002-01-10 21:03 ` Badari Pulavarty
2002-01-10 21:26 ` Alan Cox
2002-01-10 21:15 ` Badari Pulavarty
2002-01-15 3:16 ` Joel Becker
2002-01-10 7:12 ` Jens Axboe [this message]
2002-01-09 18:13 ` Jens Axboe
2002-01-09 22:56 ` Alan Cox
2002-01-09 23:20 ` Badari Pulavarty
2002-01-10 0:23 ` Alan Cox
2002-01-10 4:06 ` GOTO Masanori
[not found] <200201091741.g09HfAI17240@eng2.beaverton.ibm.com.suse.lists.linux.kernel>
[not found] ` <20020109125845.B12609@redhat.com.suse.lists.linux.kernel>
2002-01-09 18:15 ` Andi Kleen
[not found] <200201102153.g0ALrl402482@eng2.beaverton.ibm.com>
2002-01-10 22:11 ` Alan Cox
2002-01-10 22:20 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020110081252.P19814@suse.de \
--to=axboe@suse.de \
--cc=andrea@suse.de \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox