public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@redhat.com>
To: Brian Gerst <bgerst@didntduck.org>
Cc: f.jimenez@bigfoot.com, linux-kernel@vger.kernel.org
Subject: Re: array size limit in module?
Date: Thu, 10 Jan 2002 13:37:56 -0500	[thread overview]
Message-ID: <20020110133756.A8433@redhat.com> (raw)
In-Reply-To: <20020110181054Z289122-13997+3040@vger.kernel.org> <3C3DDAFB.E1DC0EFB@didntduck.org>
In-Reply-To: <3C3DDAFB.E1DC0EFB@didntduck.org>; from bgerst@didntduck.org on Thu, Jan 10, 2002 at 01:18:35PM -0500

On Thu, Jan 10, 2002 at 01:18:35PM -0500, Brian Gerst wrote:
> Use vmalloc for allocations that large, unless you must have the memory
> physically contiguous.  128k is the largest amount of memory you can
> allocate with kmalloc.

Even before he uses vmalloc, he should take a programming 101 course that 
explains the importance of error checking.  kmalloc returned NULL, the 
code didn't handle the case.  Switching to vmalloc will only make the code 
usually work, but still susceptible to crashing.

		-ben

  reply	other threads:[~2002-01-10 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-10 18:13 array size limit in module? Fernando Jimenez
2002-01-10 18:18 ` Brian Gerst
2002-01-10 18:37   ` Benjamin LaHaise [this message]
2002-01-10 22:01 ` Alex Bligh - linux-kernel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020110133756.A8433@redhat.com \
    --to=bcrl@redhat.com \
    --cc=bgerst@didntduck.org \
    --cc=f.jimenez@bigfoot.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox