public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Vladimir Kondratiev <vladimir.kondratiev@intel.com>
Cc: linux-kernel@vger.kernel.org, Nick Craig-Wood <ncw@axis.demon.co.uk>
Subject: Re: __FUNCTION__ - patch for USB
Date: Thu, 10 Jan 2002 08:09:27 -0800	[thread overview]
Message-ID: <20020110160927.GA26783@kroah.com> (raw)
In-Reply-To: <3C3CC04D.2080807@intel.com> <20020109222657.GA23143@kroah.com> <3C3D7289.9000302@intel.com>
In-Reply-To: <3C3D7289.9000302@intel.com>

On Thu, Jan 10, 2002 at 12:52:57PM +0200, Vladimir Kondratiev wrote:
> Patch against 2.4.18-pre2 attached. For 2.5 tree - wait a bit, I have to 
> return for a moment to business I get salary for.

You still are changing a few dbg() macros that you don't have to change.

Also, info(), warn() and err() should not have __FUNCTION__ added to
them.  Have you tried running the usb code with this patch?  The USB
group gets enough grief about all of the kernel log messages that we
spit out.  We do not need to see the function name for every message we
write (the user does not need it.)

I think I'll wait for the debug level messages cleanup in the 2.5 USB
code to make this kind of change (as talked about in a previous
message.)

thanks,

greg k-h

  reply	other threads:[~2002-01-10 16:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-09 22:12 __FUNCTION__ - patch for USB Vladimir Kondratiev
2002-01-09 22:26 ` Greg KH
2002-01-10 10:52   ` Vladimir Kondratiev
2002-01-10 16:09     ` Greg KH [this message]
2002-01-11 12:23       ` Vladimir Kondratiev
2002-01-10  9:08 ` Nick Craig-Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020110160927.GA26783@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncw@axis.demon.co.uk \
    --cc=vladimir.kondratiev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox