Re: Patch for ymfpci in 2.5.x

Linus Torvalds
2002-01-11T18:38:58Z

On Fri, 11 Jan 2002, Pete Zaitcev wrote:
>
> I am terribly sorry, but an additional fixup is needed,
> as identified by Anders Rune Jensen (mental note - always
> cc submissions to linux-kernel. So many good eyeballs).

It would have been even saner to give that bit some sane name, and have
something like

#define YMFPCI_XXXBIT (__constant_cpu_to_le32(0x40000000))

instead of creating a totally nonsensical random number.

I applied your patch, but if I had created that code I would be too
ashamed to post such a patch on a public mailing list.

Linus