From: Russell King <rmk@arm.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] O(1) scheduler, -H5
Date: Fri, 11 Jan 2002 14:58:11 +0000 [thread overview]
Message-ID: <20020111145811.B31366@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020111113131.C30756@flint.arm.linux.org.uk> <E16P1Qd-0007aL-00@the-village.bc.nu>
In-Reply-To: <E16P1Qd-0007aL-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Fri, Jan 11, 2002 at 01:09:03PM +0000
On Fri, Jan 11, 2002 at 01:09:03PM +0000, Alan Cox wrote:
> > The serial driver (old or new) open/close functions are one of the worst
> > offenders of the global-cli-and-hold-kernel-lock-and-schedule problem.
> > I'm currently working on fixing this in the new serial driver.
>
> Someone fixed serial.c to use spinlocks a long while ago. Its just not
> merged
Unfortunately it wasn't a simple "replace global irq with spinlocks" - some
code also got moved around so its not clear that the problem was fixed by
the spinlocks or the code reordering. I'd rather know which it was.
In addition, holding a spinlock while calling request_irq is asking for
trouble.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-01-11 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-11 0:38 [patch] O(1) scheduler, -H5 Ingo Molnar
2002-01-11 11:31 ` Russell King
2002-01-11 12:05 ` David S. Miller
2002-01-11 13:09 ` Alan Cox
2002-01-11 14:58 ` Russell King [this message]
2002-01-11 15:22 ` Alan Cox
2002-01-11 15:23 ` Russell King
[not found] <Pine.LNX.4.33.0201110130290.11478-100000@localhost.localdomain.suse.lists.linux.kernel>
[not found] ` <20020111113131.C30756@flint.arm.linux.org.uk.suse.lists.linux.kernel>
2002-01-11 11:42 ` Andi Kleen
2002-01-11 11:57 ` Russell King
2002-01-11 12:00 ` Arjan van de Ven
[not found] <20020111091744.B1170@w-mikek2.des.beaverton.ibm.com>
2002-01-13 17:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020111145811.B31366@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox