* 2.5: I/O errors ignored in __scsi_end_request
@ 2002-01-13 17:53 Peter Osterlund
2002-01-14 6:43 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Peter Osterlund @ 2002-01-13 17:53 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel
I/O errors in scsi drivers are being silently ignored in the
__scsi_end_request function in scsi_lib.c. This patch seems obvious
enough to me. (And it does work, at least for the packet writing
module.)
--- linux/drivers/scsi/scsi_lib.c.old Sun Jan 13 18:40:44 2002
+++ linux/drivers/scsi/scsi_lib.c Sun Jan 13 13:45:03 2002
@@ -365,7 +365,7 @@
* If there are blocks left over at the end, set up the command
* to queue the remainder of them.
*/
- if (end_that_request_first(req, 1, sectors)) {
+ if (end_that_request_first(req, uptodate, sectors)) {
if (!requeue)
return SCpnt;
--
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: 2.5: I/O errors ignored in __scsi_end_request
2002-01-13 17:53 2.5: I/O errors ignored in __scsi_end_request Peter Osterlund
@ 2002-01-14 6:43 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2002-01-14 6:43 UTC (permalink / raw)
To: Peter Osterlund; +Cc: linux-kernel
On Sun, Jan 13 2002, Peter Osterlund wrote:
> I/O errors in scsi drivers are being silently ignored in the
> __scsi_end_request function in scsi_lib.c. This patch seems obvious
> enough to me. (And it does work, at least for the packet writing
> module.)
>
> --- linux/drivers/scsi/scsi_lib.c.old Sun Jan 13 18:40:44 2002
> +++ linux/drivers/scsi/scsi_lib.c Sun Jan 13 13:45:03 2002
> @@ -365,7 +365,7 @@
> * If there are blocks left over at the end, set up the command
> * to queue the remainder of them.
> */
> - if (end_that_request_first(req, 1, sectors)) {
> + if (end_that_request_first(req, uptodate, sectors)) {
> if (!requeue)
> return SCpnt;
Irk, what a silly. Thanks, patch is obviously correct.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-01-14 6:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-01-13 17:53 2.5: I/O errors ignored in __scsi_end_request Peter Osterlund
2002-01-14 6:43 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox