Re: pci_alloc_consistent from interrupt == BAD

Russell King
2002-01-18T21:30:11Z

On Fri, Jan 18, 2002 at 12:32:21PM -0800, David S. Miller wrote:
> The ARM and PPC ports could set __GFP_HIGH in their page table
> allocation calls when invoked via pci_alloc_consistent, and this is
> the change I suggest they make. It is a trivial fix whereas backing
> out this ability to call pci_alloc_consistent from interrupts is not
> a trivial change at all.

ARM will get fixed some way if and when it becomes a requirement to fix
it. "requirement" here is defined by someone wanting to use such a
driver on an ARM system. Currently, there is no call for it, so there's
not much point in implementing it.

However, if it becomes easy to implement without impacting the code too
much, then it will get fixed in due coarse. The problem currently is
that there is no way for the page table allocation functions to know
that they should be using atomic and emergency pool memory allocations.

Its a balance of pain vs gain. Pain is currently high, gain is currently
zero.

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux