From: "David S. Miller" <davem@redhat.com>
To: martin.macok@underground.cz
Cc: linux-kernel@vger.kernel.org
Subject: Re: [andrewg@tasmail.com: remote memory reading through tcp/icmp]
Date: Sun, 20 Jan 2002 17:52:04 -0800 (PST) [thread overview]
Message-ID: <20020120.175204.18636524.davem@redhat.com> (raw)
In-Reply-To: <20020121015209.A26413@sarah.kolej.mff.cuni.cz>
In-Reply-To: <20020121015209.A26413@sarah.kolej.mff.cuni.cz>
From: Martin Mačok <martin.macok@underground.cz>
Date: Mon, 21 Jan 2002 01:52:09 +0100
Any comments on this?
Pretty simple to fix, from Andi Kleen:
--- linux-work/net/ipv4/icmp.c-o Tue Jan 15 11:05:17 2002
+++ linux-work/net/ipv4/icmp.c Sun Jan 20 23:31:29 2002
@@ -495,7 +495,7 @@
icmp_param.data.icmph.checksum=0;
icmp_param.csum=0;
icmp_param.skb=skb_in;
- icmp_param.offset=skb_in->nh.raw - skb_in->data;
+ icmp_param.offset=skb_in->data - skb_in->nh.raw;
icmp_out_count(icmp_param.data.icmph.type);
icmp_socket->sk->protinfo.af_inet.tos = tos;
ipc.addr = iph->saddr;
--- linux-work/net/ipv6/icmp.c-o Thu Sep 20 23:12:56 2001
+++ linux-work/net/ipv6/icmp.c Sun Jan 20 23:40:03 2002
@@ -361,7 +361,7 @@
msg.icmph.icmp6_pointer = htonl(info);
msg.skb = skb;
- msg.offset = skb->nh.raw - skb->data;
+ msg.offset = skb->data - skb->nh.raw;
msg.csum = 0;
msg.daddr = &hdr->saddr;
next prev parent reply other threads:[~2002-01-21 1:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-21 0:52 [andrewg@tasmail.com: remote memory reading through tcp/icmp] Martin Mačok
2002-01-21 1:52 ` David S. Miller [this message]
2002-01-21 2:12 ` Dave Jones
2002-01-21 2:43 ` David S. Miller
2002-01-21 14:14 ` Russell King
2002-01-21 16:32 ` Dave Jones
2002-01-21 14:44 ` Russell King
2002-01-23 15:18 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020120.175204.18636524.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.macok@underground.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox