From: Jens Axboe <axboe@suse.de>
To: Andre Hedrick <andre@linuxdiskcert.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.5.3-pre1-aia1 (fwd)
Date: Mon, 21 Jan 2002 11:35:49 +0100 [thread overview]
Message-ID: <20020121113549.U27835@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.10.10201210149290.13727-200000@master.linux-ide.org>
In-Reply-To: <Pine.LNX.4.10.10201210149290.13727-200000@master.linux-ide.org>
On Mon, Jan 21 2002, Andre Hedrick wrote:
> @@ -189,13 +189,14 @@
> memset(&taskfile, 0, sizeof(task_struct_t));
> memset(&hobfile, 0, sizeof(hob_struct_t));
>
> - sectors = rq->nr_sectors;
> if (sectors == 256)
> sectors = 0;
> - if (command == WIN_MULTWRITE_EXT || command == WIN_MULTWRITE) {
> + if (command == WIN_MULTWRITE) {
> sectors = drive->mult_count;
> if (sectors > rq->current_nr_sectors)
> sectors = rq->current_nr_sectors;
> + if (sectors != drive->mult_count)
> + command = WIN_WRITE;
I think this is too restrictive, something ala
if (sectors % drive->mult_count)
command = WIN_WRITE;
should suffice. However, we still need to cover the read... So something
like this maybe:
if (sectors % drive->mult_count)
don't use multi write _or_ read, use WIN_{READ,WRITE}
/* usual setup */
> - sectors = rq->nr_sectors;
> - if (sectors == 256)
> + if (sectors == 65536)
> sectors = 0;
Yeah this was my silly, sorry.
--
Jens Axboe
next prev parent reply other threads:[~2002-01-21 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-21 9:50 Linux 2.5.3-pre1-aia1 (fwd) Andre Hedrick
2002-01-21 10:35 ` Jens Axboe [this message]
2002-01-21 10:40 ` Jens Axboe
2002-01-21 16:35 ` Oliver Xymoron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020121113549.U27835@suse.de \
--to=axboe@suse.de \
--cc=andre@linuxdiskcert.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox