From: Pete Zaitcev <zaitcev@redhat.com>
To: "David S. Miller" <davem@redhat.com>
Cc: zaitcev@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: pci_alloc_consistent from interrupt == BAD
Date: Mon, 21 Jan 2002 19:20:52 -0500 [thread overview]
Message-ID: <20020121192052.A8752@devserv.devel.redhat.com> (raw)
In-Reply-To: <3C4875DB.9080402@embeddededge.com> <mailman.1011386221.24072.linux-kernel2news@redhat.com> <200201212352.g0LNq5802844@devserv.devel.redhat.com> <20020121.160853.10161323.davem@redhat.com>
In-Reply-To: <20020121.160853.10161323.davem@redhat.com>; from davem@redhat.com on Mon, Jan 21, 2002 at 04:08:53PM -0800
> Date: Mon, 21 Jan 2002 16:08:53 -0800 (PST)
> From: "David S. Miller" <davem@redhat.com>
>
> From: Pete Zaitcev <zaitcev@redhat.com>
> Date: Mon, 21 Jan 2002 18:52:05 -0500
>
> > It [GFP_HIGH] is a trivial fix whereas backing
> > out this ability to call pci_alloc_consistent from interrupts is not
> > a trivial change at all.
>
> David, would you make a statement about pci_free_consistent.
> I find it annoying that it cannot be called from an interrupt.
>
> It is not an unreasonable requirement. Wasn't there some problem with
> the pci pool stuff if it free'd up a chunk in an interrupt?
Yes, the pci_pool_free is one of the reasons why I ask.
I understand that the fundamental difference is that
allocation can fail (given right GFP flag), so this is what
we do in an interrupt (and we drop a packet in the driver).
But frees cannot fail, so if that tries to slip then we are stuck.
-- Pete
next prev parent reply other threads:[~2002-01-22 0:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-18 19:02 pci_alloc_consistent from interrupt == BAD Troy Benjegerdes
2002-01-18 19:22 ` Dan Malek
2002-01-18 20:32 ` David S. Miller
2002-01-18 21:29 ` Russell King
2002-01-18 21:33 ` David S. Miller
2002-01-18 21:42 ` Russell King
2002-01-18 21:46 ` Dan Malek
2002-01-18 21:55 ` Russell King
2002-01-18 22:13 ` Dan Malek
2002-01-18 21:43 ` Dan Malek
2002-01-18 20:50 ` Gérard Roudier
[not found] ` <mailman.1011386221.24072.linux-kernel2news@redhat.com>
2002-01-21 23:52 ` Pete Zaitcev
2002-01-22 0:08 ` David S. Miller
2002-01-22 0:20 ` Pete Zaitcev [this message]
2002-01-18 20:21 ` Gérard Roudier
2002-01-18 20:38 ` David S. Miller
2002-01-18 21:07 ` Gérard Roudier
2002-01-18 21:13 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2002-01-19 17:21 David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020121192052.A8752@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox