From: Pete Zaitcev <zaitcev@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, zaitcev@redhat.com
Subject: Re: Fwd: Re: 2.4.17:Increase number of anonymous filesystems beyond 256?
Date: Tue, 22 Jan 2002 12:32:20 -0500 [thread overview]
Message-ID: <20020122123220.A27968@devserv.devel.redhat.com> (raw)
In-Reply-To: <200201171351.g0HDpdK05456@bliss.uni-koblenz.de.suse.lists.linux.kernel> <mailman.1011289920.22682.linux-kernel2news@redhat.com>
In-Reply-To: <mailman.1011289920.22682.linux-kernel2news@redhat.com>; from ak@suse.de on Thu, Jan 17, 2002 at 06:49:53PM +0100
> From: Andi Kleen <ak@suse.de>
> Newsgroups: linux-kernel
> Date: 17 Jan 2002 18:49:53 +0100
> --- linux-work/net/sunrpc/xprt.c-o Mon Oct 8 21:36:07 2001
> +++ linux-work/net/sunrpc/xprt.c Thu Jan 17 18:44:05 2002
> @@ -1507,6 +1507,13 @@
>
> memset(&myaddr, 0, sizeof(myaddr));
> myaddr.sin_family = AF_INET;
> +#define SUNRPC_NONSECURE_PORT 1
> +#ifdef SUNRPC_NONSECURE_PORT
> + err = sock->ops->bind(sock, (struct sockaddr *) &myaddr,
> + sizeof(myaddr));
> + if (err < 0)
> + printk("RPC: cannot bind to a port\n");
> +#else
> port = 800;
> do {
> myaddr.sin_port = htons(port);
> @@ -1516,6 +1523,9 @@
>
> if (err < 0)
> printk("RPC: Can't bind to reserved port (%d).\n", -err);
> +
> +#endif
> +
>
> return err;
> }
Andi, the patch above begs two questions in my mind:
1. Why to bind to 0 (INADDR_ANY) explicitly? My patch does not bind
at all and expects connect() to bind automatically. It is how
userland works and it seems to work here as well.
2. What did you do to increase the number of unnamed devices?
You said the patch "should" work, did that mean you did not test it?
-- Pete
next prev parent reply other threads:[~2002-01-22 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200201171351.g0HDpdK05456@bliss.uni-koblenz.de.suse.lists.linux.kernel>
2002-01-17 17:49 ` 2.4.17:Increase number of anonymous filesystems beyond 256? Andi Kleen
[not found] ` <mailman.1011289920.22682.linux-kernel2news@redhat.com>
2002-01-22 17:32 ` Pete Zaitcev [this message]
2002-01-22 22:17 ` Fwd: " Andi Kleen
2002-01-22 22:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020122123220.A27968@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox