public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: drobbins@gentoo.org
Cc: linux-kernel@vger.kernel.org, andrea@suse.de, alan@redhat.com,
	akpm@zip.com.au, vherva@niksula.hut.fi, lwn@lwn.net
Subject: Re: Athlon/AGP issue update
Date: Wed, 23 Jan 2002 02:18:19 -0800 (PST)	[thread overview]
Message-ID: <20020123.021819.21955581.davem@redhat.com> (raw)
In-Reply-To: <1011779573.9368.40.camel@inventor.gentoo.org>
In-Reply-To: <1011779573.9368.40.camel@inventor.gentoo.org>


This means that the fix belongs in the DRM drivers, specifically
DRM(mmap_dma) should clear the cacheability bits in the
vma->vm_page_prot at mmap time.

I always thought the idea was that the AGP device accessed main memory
through GART with full cache coherency with the processor.  This
should be pretty easy to implement since the PCI controller has to do
this already.

I'm really surprised that both the NVIDIA driver and DRM both get this
wrong.

Actually, the AMD guys say this:

	This situation is fundamentally illegal because GART is non-coherent and
	all translations that the processor could use to access the AGP memory
	must, therefore, be non-cacheable.  Although we have seen no intentional
	access to the AGP memory by the processor via the 4MB cacheable
	translation we have seen legitimate, speculative, accesses performed by
	the processor.

"access by the processor" to the 4MB cacheable translation or
somewhere else?  This needs clarification.

Disabling 4MB translations has zero effect on the problem they say is
the root all of this.  The mappings given to the OpenGL driver to the
GART memory is still going to be cacheable, thus the problem ought to
still exist.

As usual, AMD's commentary brings more questions than it answers.

  reply	other threads:[~2002-01-23 10:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-23  9:52 Athlon/AGP issue update Daniel Robbins
2002-01-23 10:18 ` David S. Miller [this message]
2002-01-23  2:46   ` benh
2002-01-23 14:08     ` David S. Miller
2002-01-23 15:47       ` benh
2002-01-25 18:34         ` Val Henson
2002-01-26  0:20           ` Benjamin Herrenschmidt
2002-01-27 19:22             ` Val Henson
2002-01-27 19:32               ` Benjamin Herrenschmidt
2002-01-23 16:31       ` Albert D. Cahalan
2002-01-23 16:57         ` Daniel Robbins
2002-01-23 17:14         ` benh
2002-01-23 23:14           ` Albert D. Cahalan
2002-01-25 18:17             ` Val Henson
2002-01-23 19:20   ` Oliver Neukum
     [not found] ` <200201231010.g0NAAuE05886@Port.imtp.ilyichevsk.odessa.ua>
2002-01-23 10:24   ` David S. Miller
2002-01-23 10:31     ` Rik van Riel
2002-01-23 11:39       ` David S. Miller
2002-01-23 11:39     ` William Lee Irwin III
2002-01-23 11:47       ` David S. Miller
2002-01-23 17:09         ` Albert D. Cahalan
2002-01-23 18:38           ` David S. Miller
  -- strict thread matches above, loose matches on Subject: below --
2002-01-23 10:38 Studierende der Universitaet des Saarlandes
2002-01-23 11:44 ` David S. Miller
2002-01-23 12:32   ` Momchil Velikov
2002-01-23 12:34     ` David S. Miller
2002-01-23 12:41       ` Momchil Velikov
2002-01-23 14:50   ` Manfred Spraul
2002-01-23 11:44 ` David Woodhouse
2002-01-23 11:49   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020123.021819.21955581.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=akpm@zip.com.au \
    --cc=alan@redhat.com \
    --cc=andrea@suse.de \
    --cc=drobbins@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lwn@lwn.net \
    --cc=vherva@niksula.hut.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox