public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* depmod problem for 2.5.2-dj4
@ 2002-01-23  0:12 Torrey Hoffman
  2002-01-23  4:54 ` Greg KH
  0 siblings, 1 reply; 12+ messages in thread
From: Torrey Hoffman @ 2002-01-23  0:12 UTC (permalink / raw)
  To: Linux Kernel

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

during make modules_install:

if [ -r System.map ]; then /sbin/depmod -ae -F System.map  2.5.2-dj4; fi
depmod: *** Unresolved symbols in
/lib/modules/2.5.2-dj4/kernel/drivers/net/sis900.o
depmod: 	crc32_be_Rb7b61546
depmod: *** Unresolved symbols in
/lib/modules/2.5.2-dj4/kernel/drivers/usb/hid.o
depmod: 	usb_make_path
depmod: *** Unresolved symbols in
/lib/modules/2.5.2-dj4/kernel/drivers/usb/usbkbd.o
depmod: 	usb_make_path
depmod: *** Unresolved symbols in
/lib/modules/2.5.2-dj4/kernel/drivers/usb/usbmouse.o
depmod: 	usb_make_path
make: *** [_modinst_post] Error 1

My .config is attached.


Torrey

[-- Attachment #2: .config --]
[-- Type: text/plain, Size: 25587 bytes --]

#
# Automatically generated make config: don't edit
#
CONFIG_X86=y
CONFIG_ISA=y
# CONFIG_SBUS is not set
CONFIG_UID16=y

#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y

#
# Loadable module support
#
CONFIG_MODULES=y
CONFIG_MODVERSIONS=y
CONFIG_KMOD=y

#
# Processor type and features
#
# CONFIG_M386 is not set
# CONFIG_M486 is not set
# CONFIG_M586 is not set
# CONFIG_M586TSC is not set
# CONFIG_M586MMX is not set
# CONFIG_M686 is not set
CONFIG_MPENTIUMIII=y
# CONFIG_MPENTIUM4 is not set
# CONFIG_MK6 is not set
# CONFIG_MK7 is not set
# CONFIG_MCRUSOE is not set
# CONFIG_MWINCHIPC6 is not set
# CONFIG_MWINCHIP2 is not set
# CONFIG_MWINCHIP3D is not set
# CONFIG_MCYRIXIII is not set
CONFIG_X86_WP_WORKS_OK=y
CONFIG_X86_INVLPG=y
CONFIG_X86_CMPXCHG=y
CONFIG_X86_XADD=y
CONFIG_X86_BSWAP=y
CONFIG_X86_POPAD_OK=y
# CONFIG_RWSEM_GENERIC_SPINLOCK is not set
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_X86_L1_CACHE_SHIFT=5
CONFIG_X86_TSC=y
CONFIG_X86_GOOD_APIC=y
CONFIG_X86_PGE=y
CONFIG_X86_USE_PPRO_CHECKSUM=y
# CONFIG_TOSHIBA is not set
# CONFIG_I8K is not set
CONFIG_MICROCODE=m
CONFIG_X86_MSR=m
CONFIG_X86_CPUID=m
CONFIG_NOHIGHMEM=y
# CONFIG_HIGHMEM4G is not set
# CONFIG_HIGHMEM64G is not set
# CONFIG_MATH_EMULATION is not set
CONFIG_MTRR=y
# CONFIG_SMP is not set
# CONFIG_X86_UP_APIC is not set
# CONFIG_X86_UP_IOAPIC is not set

#
# General setup
#
CONFIG_NET=y
CONFIG_PCI=y
# CONFIG_PCI_GOBIOS is not set
# CONFIG_PCI_GODIRECT is not set
CONFIG_PCI_GOANY=y
CONFIG_PCI_BIOS=y
CONFIG_PCI_DIRECT=y
CONFIG_PCI_NAMES=y
# CONFIG_EISA is not set
# CONFIG_MCA is not set
CONFIG_HOTPLUG=y

#
# PCMCIA/CardBus support
#
# CONFIG_PCMCIA is not set

#
# PCI Hotplug Support
#
# CONFIG_HOTPLUG_PCI is not set
# CONFIG_HOTPLUG_PCI_COMPAQ is not set
# CONFIG_HOTPLUG_PCI_COMPAQ_NVRAM is not set
CONFIG_SYSVIPC=y
CONFIG_BSD_PROCESS_ACCT=y
CONFIG_SYSCTL=y
CONFIG_KCORE_ELF=y
# CONFIG_KCORE_AOUT is not set
CONFIG_BINFMT_AOUT=m
CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_MISC=m
CONFIG_PM=y
# CONFIG_ACPI is not set
CONFIG_APM=y
# CONFIG_APM_IGNORE_USER_SUSPEND is not set
CONFIG_APM_DO_ENABLE=y
CONFIG_APM_CPU_IDLE=y
# CONFIG_APM_DISPLAY_BLANK is not set
CONFIG_APM_RTC_IS_GMT=y
# CONFIG_APM_ALLOW_INTS is not set
# CONFIG_APM_REAL_MODE_POWER_OFF is not set

#
# Memory Technology Devices (MTD)
#
# CONFIG_MTD is not set

#
# Parallel port support
#
CONFIG_PARPORT=m
CONFIG_PARPORT_PC=m
CONFIG_PARPORT_PC_CML1=m
# CONFIG_PARPORT_SERIAL is not set
# CONFIG_PARPORT_PC_FIFO is not set
# CONFIG_PARPORT_PC_SUPERIO is not set
# CONFIG_PARPORT_AMIGA is not set
# CONFIG_PARPORT_MFC3 is not set
# CONFIG_PARPORT_ATARI is not set
# CONFIG_PARPORT_GSC is not set
# CONFIG_PARPORT_SUNBPP is not set
# CONFIG_PARPORT_OTHER is not set
CONFIG_PARPORT_1284=y

#
# Plug and Play configuration
#
CONFIG_PNP=y
# CONFIG_ISAPNP is not set
CONFIG_PNPBIOS=y

#
# Block devices
#
# CONFIG_BLK_DEV_FD is not set
# CONFIG_BLK_DEV_XD is not set
# CONFIG_PARIDE is not set
# CONFIG_BLK_CPQ_DA is not set
# CONFIG_BLK_CPQ_CISS_DA is not set
# CONFIG_CISS_SCSI_TAPE is not set
# CONFIG_BLK_DEV_DAC960 is not set
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_NBD=m
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_SIZE=4096
CONFIG_BLK_DEV_INITRD=y

#
# Multi-device support (RAID and LVM)
#
# CONFIG_MD is not set
# CONFIG_BLK_DEV_MD is not set
# CONFIG_MD_LINEAR is not set
# CONFIG_MD_RAID0 is not set
# CONFIG_MD_RAID1 is not set
# CONFIG_MD_RAID5 is not set
# CONFIG_MD_MULTIPATH is not set
# CONFIG_BLK_DEV_LVM is not set

#
# Networking options
#
CONFIG_PACKET=y
CONFIG_PACKET_MMAP=y
CONFIG_NETLINK_DEV=y
CONFIG_NETFILTER=y
# CONFIG_NETFILTER_DEBUG is not set
CONFIG_FILTER=y
CONFIG_UNIX=y
CONFIG_INET=y
CONFIG_IP_MULTICAST=y
# CONFIG_IP_ADVANCED_ROUTER is not set
# CONFIG_IP_PNP is not set
CONFIG_NET_IPIP=m
CONFIG_NET_IPGRE=m
# CONFIG_NET_IPGRE_BROADCAST is not set
CONFIG_IP_MROUTE=y
# CONFIG_IP_PIMSM_V1 is not set
# CONFIG_IP_PIMSM_V2 is not set
# CONFIG_ARPD is not set
CONFIG_INET_ECN=y
CONFIG_SYN_COOKIES=y

#
#   IP: Netfilter Configuration
#
CONFIG_IP_NF_CONNTRACK=m
CONFIG_IP_NF_FTP=m
# CONFIG_IP_NF_IRC is not set
# CONFIG_IP_NF_QUEUE is not set
CONFIG_IP_NF_IPTABLES=m
CONFIG_IP_NF_MATCH_LIMIT=m
CONFIG_IP_NF_MATCH_MAC=m
# CONFIG_IP_NF_MATCH_MARK is not set
# CONFIG_IP_NF_MATCH_MULTIPORT is not set
# CONFIG_IP_NF_MATCH_TOS is not set
# CONFIG_IP_NF_MATCH_LENGTH is not set
# CONFIG_IP_NF_MATCH_TTL is not set
# CONFIG_IP_NF_MATCH_TCPMSS is not set
# CONFIG_IP_NF_MATCH_STATE is not set
# CONFIG_IP_NF_MATCH_UNCLEAN is not set
# CONFIG_IP_NF_MATCH_OWNER is not set
# CONFIG_IP_NF_FILTER is not set
# CONFIG_IP_NF_NAT is not set
# CONFIG_IP_NF_MANGLE is not set
# CONFIG_IP_NF_TARGET_LOG is not set
# CONFIG_IP_NF_TARGET_TCPMSS is not set
# CONFIG_IP_NF_COMPAT_IPCHAINS is not set
# CONFIG_IP_NF_COMPAT_IPFWADM is not set
CONFIG_IPV6=m

#
#   IPv6: Netfilter Configuration
#
CONFIG_IP6_NF_IPTABLES=m
CONFIG_IP6_NF_MATCH_LIMIT=m
CONFIG_IP6_NF_MATCH_MAC=m
CONFIG_IP6_NF_MATCH_MULTIPORT=m
# CONFIG_IP6_NF_MATCH_OWNER is not set
CONFIG_IP6_NF_MATCH_MARK=m
CONFIG_IP6_NF_FILTER=m
CONFIG_IP6_NF_TARGET_LOG=m
# CONFIG_IP6_NF_MANGLE is not set
# CONFIG_KHTTPD is not set
# CONFIG_ATM is not set
# CONFIG_VLAN_8021Q is not set

#
#  
#
# CONFIG_IPX is not set
# CONFIG_ATALK is not set
# CONFIG_DECNET is not set
# CONFIG_BRIDGE is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_LLC is not set
# CONFIG_NET_DIVERT is not set
# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set
# CONFIG_NET_FASTROUTE is not set
# CONFIG_NET_HW_FLOWCONTROL is not set

#
# QoS and/or fair queueing
#
# CONFIG_NET_SCHED is not set

#
# Telephony Support
#
# CONFIG_PHONE is not set
# CONFIG_PHONE_IXJ is not set
# CONFIG_PHONE_IXJ_PCMCIA is not set

#
# ATA/IDE/MFM/RLL support
#
CONFIG_IDE=y

#
# IDE, ATA and ATAPI Block devices
#
CONFIG_BLK_DEV_IDE=y

#
# Please see Documentation/ide.txt for help/info on IDE drives
#
# CONFIG_BLK_DEV_HD_IDE is not set
# CONFIG_BLK_DEV_HD is not set
CONFIG_BLK_DEV_IDEDISK=y
CONFIG_IDEDISK_MULTI_MODE=y
CONFIG_IDEDISK_STROKE=y
# CONFIG_BLK_DEV_IDEDISK_VENDOR is not set
# CONFIG_BLK_DEV_IDEDISK_FUJITSU is not set
# CONFIG_BLK_DEV_IDEDISK_IBM is not set
# CONFIG_BLK_DEV_IDEDISK_MAXTOR is not set
# CONFIG_BLK_DEV_IDEDISK_QUANTUM is not set
# CONFIG_BLK_DEV_IDEDISK_SEAGATE is not set
# CONFIG_BLK_DEV_IDEDISK_WD is not set
# CONFIG_BLK_DEV_COMMERIAL is not set
# CONFIG_BLK_DEV_TIVO is not set
# CONFIG_BLK_DEV_IDECS is not set
# CONFIG_BLK_DEV_IDECD is not set
# CONFIG_BLK_DEV_IDETAPE is not set
# CONFIG_BLK_DEV_IDEFLOPPY is not set
CONFIG_BLK_DEV_IDESCSI=y
CONFIG_IDE_TASK_IOCTL=y

#
# IDE chipset support/bugfixes
#
# CONFIG_BLK_DEV_CMD640 is not set
# CONFIG_BLK_DEV_CMD640_ENHANCED is not set
# CONFIG_BLK_DEV_ISAPNP is not set
# CONFIG_BLK_DEV_RZ1000 is not set
CONFIG_BLK_DEV_IDEPCI=y
CONFIG_IDEPCI_SHARE_IRQ=y
CONFIG_BLK_DEV_IDEDMA_PCI=y
# CONFIG_BLK_DEV_OFFBOARD is not set
# CONFIG_BLK_DEV_IDEDMA_FORCED is not set
CONFIG_IDEDMA_PCI_AUTO=y
# CONFIG_IDEDMA_ONLYDISK is not set
CONFIG_BLK_DEV_IDEDMA=y
# CONFIG_IDEDMA_PCI_WIP is not set
# CONFIG_BLK_DEV_IDEDMA_TIMEOUT is not set
# CONFIG_IDEDMA_NEW_DRIVE_LISTINGS is not set
CONFIG_BLK_DEV_ADMA=y
# CONFIG_BLK_DEV_AEC62XX is not set
# CONFIG_AEC62XX_TUNING is not set
# CONFIG_BLK_DEV_ALI15X3 is not set
# CONFIG_WDC_ALI15X3 is not set
# CONFIG_BLK_DEV_AMD74XX is not set
# CONFIG_AMD74XX_OVERRIDE is not set
# CONFIG_BLK_DEV_CMD64X is not set
# CONFIG_BLK_DEV_CY82C693 is not set
# CONFIG_BLK_DEV_CS5530 is not set
# CONFIG_BLK_DEV_HPT34X is not set
# CONFIG_HPT34X_AUTODMA is not set
# CONFIG_BLK_DEV_HPT366 is not set
CONFIG_BLK_DEV_PIIX=y
CONFIG_PIIX_TUNING=y
# CONFIG_BLK_DEV_NS87415 is not set
# CONFIG_BLK_DEV_OPTI621 is not set
# CONFIG_BLK_DEV_PDC_ADMA is not set
# CONFIG_BLK_DEV_PDC202XX is not set
# CONFIG_PDC202XX_BURST is not set
# CONFIG_PDC202XX_FORCE is not set
# CONFIG_BLK_DEV_SVWKS is not set
CONFIG_BLK_DEV_SIS5513=y
# CONFIG_BLK_DEV_SLC90E66 is not set
# CONFIG_BLK_DEV_TRM290 is not set
# CONFIG_BLK_DEV_VIA82CXXX is not set
# CONFIG_IDE_CHIPSETS is not set
CONFIG_IDEDMA_AUTO=y
# CONFIG_IDEDMA_IVB is not set
# CONFIG_DMA_NONPCI is not set
CONFIG_BLK_DEV_IDE_MODES=y
# CONFIG_BLK_DEV_ATARAID is not set
# CONFIG_BLK_DEV_ATARAID_PDC is not set
# CONFIG_BLK_DEV_ATARAID_HPT is not set

#
# SCSI support
#
CONFIG_SCSI=y

#
# SCSI support type (disk, tape, CD-ROM)
#
# CONFIG_BLK_DEV_SD is not set
# CONFIG_CHR_DEV_ST is not set
# CONFIG_CHR_DEV_OSST is not set
CONFIG_BLK_DEV_SR=y
# CONFIG_BLK_DEV_SR_VENDOR is not set
CONFIG_SR_EXTRA_DEVS=2
CONFIG_CHR_DEV_SG=y

#
# Some SCSI devices (e.g. CD jukebox) support multiple LUNs
#
# CONFIG_SCSI_MULTI_LUN is not set
CONFIG_SCSI_CONSTANTS=y
# CONFIG_SCSI_LOGGING is not set

#
# SCSI low-level drivers
#
# CONFIG_BLK_DEV_3W_XXXX_RAID is not set
# CONFIG_SCSI_7000FASST is not set
# CONFIG_SCSI_ACARD is not set
# CONFIG_SCSI_AHA152X is not set
# CONFIG_SCSI_AHA1542 is not set
# CONFIG_SCSI_AHA1740 is not set
# CONFIG_SCSI_AACRAID is not set
# CONFIG_SCSI_AIC7XXX is not set
# CONFIG_SCSI_AIC7XXX_OLD is not set
# CONFIG_SCSI_DPT_I2O is not set
# CONFIG_SCSI_ADVANSYS is not set
# CONFIG_SCSI_IN2000 is not set
# CONFIG_SCSI_AM53C974 is not set
# CONFIG_SCSI_MEGARAID is not set
# CONFIG_SCSI_BUSLOGIC is not set
# CONFIG_SCSI_CPQFCTS is not set
# CONFIG_SCSI_DMX3191D is not set
# CONFIG_SCSI_DTC3280 is not set
# CONFIG_SCSI_EATA is not set
# CONFIG_SCSI_EATA_DMA is not set
# CONFIG_SCSI_EATA_PIO is not set
# CONFIG_SCSI_FUTURE_DOMAIN is not set
# CONFIG_SCSI_GDTH is not set
# CONFIG_SCSI_GENERIC_NCR5380 is not set
# CONFIG_SCSI_IPS is not set
# CONFIG_SCSI_INITIO is not set
# CONFIG_SCSI_INIA100 is not set
# CONFIG_SCSI_PPA is not set
# CONFIG_SCSI_IMM is not set
# CONFIG_SCSI_NCR53C406A is not set
# CONFIG_SCSI_NCR53C7xx is not set
# CONFIG_SCSI_SYM53C8XX_2 is not set
# CONFIG_SCSI_NCR53C8XX is not set
# CONFIG_SCSI_SYM53C8XX is not set
# CONFIG_SCSI_PAS16 is not set
# CONFIG_SCSI_PCI2000 is not set
# CONFIG_SCSI_PCI2220I is not set
# CONFIG_SCSI_PSI240I is not set
# CONFIG_SCSI_QLOGIC_FAS is not set
# CONFIG_SCSI_QLOGIC_ISP is not set
# CONFIG_SCSI_QLOGIC_FC is not set
# CONFIG_SCSI_QLOGIC_1280 is not set
# CONFIG_SCSI_SEAGATE is not set
# CONFIG_SCSI_SIM710 is not set
# CONFIG_SCSI_SYM53C416 is not set
# CONFIG_SCSI_DC390T is not set
# CONFIG_SCSI_T128 is not set
# CONFIG_SCSI_U14_34F is not set
# CONFIG_SCSI_ULTRASTOR is not set
# CONFIG_SCSI_DEBUG is not set

#
# Fusion MPT device support
#
# CONFIG_FUSION is not set
# CONFIG_FUSION_BOOT is not set
# CONFIG_FUSION_ISENSE is not set
# CONFIG_FUSION_CTL is not set
# CONFIG_FUSION_LAN is not set

#
# IEEE 1394 (FireWire) support (EXPERIMENTAL)
#
# CONFIG_IEEE1394 is not set

#
# I2O device support
#
CONFIG_I2O=m
CONFIG_I2O_PCI=m
# CONFIG_I2O_BLOCK is not set
# CONFIG_I2O_LAN is not set
# CONFIG_I2O_SCSI is not set
CONFIG_I2O_PROC=m

#
# Network device support
#
CONFIG_NETDEVICES=y

#
# ARCnet devices
#
# CONFIG_ARCNET is not set
CONFIG_DUMMY=m
CONFIG_BONDING=m
# CONFIG_EQUALIZER is not set
# CONFIG_TUN is not set
# CONFIG_ETHERTAP is not set

#
# Ethernet (10 or 100Mbit)
#
CONFIG_NET_ETHERNET=y
# CONFIG_SUNLANCE is not set
# CONFIG_HAPPYMEAL is not set
# CONFIG_SUNBMAC is not set
# CONFIG_SUNQE is not set
# CONFIG_SUNLANCE is not set
# CONFIG_SUNGEM is not set
# CONFIG_NET_VENDOR_3COM is not set
# CONFIG_LANCE is not set
# CONFIG_NET_VENDOR_SMC is not set
# CONFIG_NET_VENDOR_RACAL is not set
# CONFIG_AT1700 is not set
# CONFIG_DEPCA is not set
# CONFIG_HP100 is not set
# CONFIG_NET_ISA is not set
CONFIG_NET_PCI=y
# CONFIG_PCNET32 is not set
# CONFIG_ADAPTEC_STARFIRE is not set
# CONFIG_AC3200 is not set
# CONFIG_APRICOT is not set
# CONFIG_CS89x0 is not set
# CONFIG_DE2104X is not set
# CONFIG_TULIP is not set
# CONFIG_DE4X5 is not set
# CONFIG_DGRS is not set
# CONFIG_DM9102 is not set
CONFIG_EEPRO100=m
# CONFIG_LNE390 is not set
# CONFIG_FEALNX is not set
CONFIG_NATSEMI=m
# CONFIG_NE2K_PCI is not set
# CONFIG_NE3210 is not set
# CONFIG_ES3210 is not set
# CONFIG_8139CP is not set
# CONFIG_8139TOO is not set
# CONFIG_8139TOO_PIO is not set
# CONFIG_8139TOO_TUNE_TWISTER is not set
# CONFIG_8139TOO_8129 is not set
# CONFIG_8139_NEW_RX_RESET is not set
CONFIG_SIS900=m
# CONFIG_EPIC100 is not set
# CONFIG_SUNDANCE is not set
# CONFIG_TLAN is not set
# CONFIG_VIA_RHINE is not set
# CONFIG_VIA_RHINE_MMIO is not set
# CONFIG_WINBOND_840 is not set
# CONFIG_NET_POCKET is not set

#
# Ethernet (1000 Mbit)
#
# CONFIG_ACENIC is not set
# CONFIG_DL2K is not set
# CONFIG_MYRI_SBUS is not set
# CONFIG_NS83820 is not set
# CONFIG_HAMACHI is not set
# CONFIG_YELLOWFIN is not set
# CONFIG_SK98LIN is not set
# CONFIG_FDDI is not set
# CONFIG_HIPPI is not set
# CONFIG_PLIP is not set
# CONFIG_PPP is not set
# CONFIG_SLIP is not set

#
# Wireless LAN (non-hamradio)
#
# CONFIG_NET_RADIO is not set

#
# Token Ring devices
#
# CONFIG_TR is not set
# CONFIG_NET_FC is not set
# CONFIG_RCPCI is not set
# CONFIG_SHAPER is not set

#
# Wan interfaces
#
# CONFIG_WAN is not set

#
# Amateur Radio support
#
# CONFIG_HAMRADIO is not set

#
# IrDA (infrared) support
#
# CONFIG_IRDA is not set

#
# ISDN subsystem
#
# CONFIG_ISDN is not set

#
# Old CD-ROM drivers (not SCSI, not IDE)
#
# CONFIG_CD_NO_IDESCSI is not set

#
# Input device support
#
CONFIG_INPUT=y
CONFIG_INPUT_KEYBDEV=y
CONFIG_INPUT_MOUSEDEV=y
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
CONFIG_INPUT_JOYDEV=m
CONFIG_INPUT_TSDEV=m
CONFIG_INPUT_EVDEV=m
# CONFIG_INPUT_EVBUG is not set
CONFIG_GAMEPORT=m
CONFIG_SOUND_GAMEPORT=m
CONFIG_GAMEPORT_NS558=m
# CONFIG_GAMEPORT_L4 is not set
# CONFIG_INPUT_EMU10K1 is not set
# CONFIG_GAMEPORT_VORTEX is not set
# CONFIG_GAMEPORT_FM801 is not set
CONFIG_GAMEPORT_CS461x=m
CONFIG_SERIO=y
CONFIG_SERIO_I8042=y
CONFIG_SERIO_SERPORT=y
CONFIG_SERIO_CT82C710=y
# CONFIG_SERIO_PARKBD is not set
CONFIG_INPUT_KEYBOARD=y
CONFIG_KEYBOARD_ATKBD=y
# CONFIG_KEYBOARD_SUNKBD is not set
# CONFIG_KEYBOARD_PS2SERKBD is not set
# CONFIG_KEYBOARD_XTKBD is not set
CONFIG_INPUT_MOUSE=y
CONFIG_MOUSE_PS2=y
# CONFIG_MOUSE_SERIAL is not set
# CONFIG_MOUSE_GUNZE is not set
# CONFIG_MOUSE_INPORT is not set
# CONFIG_MOUSE_LOGIBM is not set
# CONFIG_MOUSE_PC110PAD is not set
CONFIG_INPUT_JOYSTICK=y
CONFIG_JOYSTICK_ANALOG=m
# CONFIG_JOYSTICK_A3D is not set
CONFIG_JOYSTICK_ADI=m
# CONFIG_JOYSTICK_COBRA is not set
# CONFIG_JOYSTICK_GF2K is not set
# CONFIG_JOYSTICK_GRIP is not set
# CONFIG_JOYSTICK_GUILLEMOT is not set
# CONFIG_JOYSTICK_INTERACT is not set
# CONFIG_JOYSTICK_SIDEWINDER is not set
# CONFIG_JOYSTICK_TMDC is not set
# CONFIG_JOYSTICK_IFORCE_USB is not set
# CONFIG_JOYSTICK_IFORCE_232 is not set
# CONFIG_JOYSTICK_WARRIOR is not set
# CONFIG_JOYSTICK_MAGELLAN is not set
# CONFIG_JOYSTICK_SPACEORB is not set
# CONFIG_JOYSTICK_SPACEBALL is not set
# CONFIG_JOYSTICK_STINGER is not set
# CONFIG_JOYSTICK_TWIDDLER is not set
# CONFIG_JOYSTICK_DB9 is not set
# CONFIG_JOYSTICK_GAMECON is not set
# CONFIG_JOYSTICK_TURBOGRAFX is not set

#
# Character devices
#
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_SERIAL=y
CONFIG_SERIAL_CONSOLE=y
# CONFIG_SERIAL_EXTENDED is not set
# CONFIG_SERIAL_NONSTANDARD is not set
CONFIG_UNIX98_PTYS=y
CONFIG_UNIX98_PTY_COUNT=256
CONFIG_PRINTER=m
# CONFIG_LP_CONSOLE is not set
CONFIG_PPDEV=m

#
# I2C support
#
CONFIG_I2C=m
CONFIG_I2C_ALGOBIT=m
# CONFIG_I2C_PHILIPSPAR is not set
# CONFIG_I2C_ELV is not set
# CONFIG_I2C_VELLEMAN is not set
CONFIG_I2C_ALGOPCF=m
# CONFIG_I2C_ELEKTOR is not set
CONFIG_I2C_CHARDEV=m
CONFIG_I2C_PROC=m
# CONFIG_QIC02_TAPE is not set

#
# Watchdog Cards
#
# CONFIG_WATCHDOG is not set
# CONFIG_INTEL_RNG is not set
CONFIG_NVRAM=m
CONFIG_RTC=m
# CONFIG_DTLK is not set
# CONFIG_R3964 is not set
# CONFIG_APPLICOM is not set
# CONFIG_SONYPI is not set

#
# Ftape, the floppy tape device driver
#
# CONFIG_FTAPE is not set
CONFIG_AGP=y
# CONFIG_AGP_INTEL is not set
# CONFIG_AGP_I810 is not set
# CONFIG_AGP_VIA is not set
# CONFIG_AGP_AMD is not set
CONFIG_AGP_SIS=y
# CONFIG_AGP_ALI is not set
# CONFIG_AGP_SWORKS is not set
CONFIG_DRM=y
# CONFIG_DRM_TDFX is not set
# CONFIG_DRM_GAMMA is not set
# CONFIG_DRM_R128 is not set
# CONFIG_DRM_RADEON is not set
# CONFIG_DRM_I810 is not set
# CONFIG_DRM_MGA is not set
CONFIG_DRM_SIS=y
# CONFIG_MWAVE is not set

#
# Multimedia devices
#
# CONFIG_VIDEO_DEV is not set

#
# File systems
#
# CONFIG_QUOTA is not set
# CONFIG_AUTOFS_FS is not set
# CONFIG_AUTOFS4_FS is not set
CONFIG_REISERFS_FS=y
# CONFIG_REISERFS_CHECK is not set
# CONFIG_REISERFS_PROC_INFO is not set
# CONFIG_ADFS_FS is not set
# CONFIG_ADFS_FS_RW is not set
# CONFIG_AFFS_FS is not set
# CONFIG_HFS_FS is not set
# CONFIG_BFS_FS is not set
# CONFIG_EXT3_FS is not set
# CONFIG_JBD is not set
# CONFIG_JBD_DEBUG is not set
# CONFIG_FAT_FS is not set
# CONFIG_MSDOS_FS is not set
# CONFIG_UMSDOS_FS is not set
# CONFIG_VFAT_FS is not set
# CONFIG_EFS_FS is not set
# CONFIG_JFFS_FS is not set
# CONFIG_JFFS2_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_TMPFS is not set
CONFIG_RAMFS=y
CONFIG_ISO9660_FS=y
CONFIG_JOLIET=y
# CONFIG_ZISOFS is not set
# CONFIG_MINIX_FS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_NTFS_FS is not set
# CONFIG_NTFS_RW is not set
# CONFIG_HPFS_FS is not set
CONFIG_PROC_FS=y
# CONFIG_DEVFS_FS is not set
# CONFIG_DEVFS_MOUNT is not set
# CONFIG_DEVFS_DEBUG is not set
CONFIG_DEVPTS_FS=y
# CONFIG_QNX4FS_FS is not set
# CONFIG_QNX4FS_RW is not set
# CONFIG_ROMFS_FS is not set
CONFIG_EXT2_FS=y
# CONFIG_SYSV_FS is not set
# CONFIG_UDF_FS is not set
# CONFIG_UDF_RW is not set
# CONFIG_UFS_FS is not set
# CONFIG_UFS_FS_WRITE is not set

#
# Network File Systems
#
CONFIG_CODA_FS=m
# CONFIG_INTERMEZZO_FS is not set
CONFIG_NFS_FS=m
CONFIG_NFS_V3=y
# CONFIG_ROOT_NFS is not set
CONFIG_NFSD=m
CONFIG_NFSD_V3=y
CONFIG_SUNRPC=m
CONFIG_LOCKD=m
CONFIG_LOCKD_V4=y
CONFIG_SMB_FS=y
CONFIG_SMB_NLS_DEFAULT=y
CONFIG_SMB_NLS_REMOTE="cp437"
# CONFIG_NCP_FS is not set
# CONFIG_NCPFS_PACKET_SIGNING is not set
# CONFIG_NCPFS_IOCTL_LOCKING is not set
# CONFIG_NCPFS_STRONG is not set
# CONFIG_NCPFS_NFS_NS is not set
# CONFIG_NCPFS_OS2_NS is not set
# CONFIG_NCPFS_SMALLDOS is not set
# CONFIG_NCPFS_NLS is not set
# CONFIG_NCPFS_EXTRAS is not set
# CONFIG_ZISOFS_FS is not set
# CONFIG_ZLIB_FS_INFLATE is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y
CONFIG_SMB_NLS=y
CONFIG_NLS=y

#
# Native Language Support
#
CONFIG_NLS_DEFAULT="iso8859-1"
CONFIG_NLS_CODEPAGE_437=y
# CONFIG_NLS_CODEPAGE_737 is not set
# CONFIG_NLS_CODEPAGE_775 is not set
# CONFIG_NLS_CODEPAGE_850 is not set
# CONFIG_NLS_CODEPAGE_852 is not set
# CONFIG_NLS_CODEPAGE_855 is not set
# CONFIG_NLS_CODEPAGE_857 is not set
# CONFIG_NLS_CODEPAGE_860 is not set
# CONFIG_NLS_CODEPAGE_861 is not set
# CONFIG_NLS_CODEPAGE_862 is not set
# CONFIG_NLS_CODEPAGE_863 is not set
# CONFIG_NLS_CODEPAGE_864 is not set
# CONFIG_NLS_CODEPAGE_865 is not set
# CONFIG_NLS_CODEPAGE_866 is not set
# CONFIG_NLS_CODEPAGE_869 is not set
# CONFIG_NLS_CODEPAGE_936 is not set
# CONFIG_NLS_CODEPAGE_950 is not set
# CONFIG_NLS_CODEPAGE_932 is not set
# CONFIG_NLS_CODEPAGE_949 is not set
# CONFIG_NLS_CODEPAGE_874 is not set
# CONFIG_NLS_ISO8859_8 is not set
# CONFIG_NLS_CODEPAGE_1250 is not set
# CONFIG_NLS_CODEPAGE_1251 is not set
CONFIG_NLS_ISO8859_1=y
# CONFIG_NLS_ISO8859_2 is not set
# CONFIG_NLS_ISO8859_3 is not set
# CONFIG_NLS_ISO8859_4 is not set
# CONFIG_NLS_ISO8859_5 is not set
# CONFIG_NLS_ISO8859_6 is not set
# CONFIG_NLS_ISO8859_7 is not set
# CONFIG_NLS_ISO8859_9 is not set
# CONFIG_NLS_ISO8859_13 is not set
# CONFIG_NLS_ISO8859_14 is not set
# CONFIG_NLS_ISO8859_15 is not set
# CONFIG_NLS_KOI8_R is not set
# CONFIG_NLS_KOI8_U is not set
# CONFIG_NLS_UTF8 is not set

#
# Console drivers
#
CONFIG_VGA_CONSOLE=y
CONFIG_VIDEO_SELECT=y
# CONFIG_MDA_CONSOLE is not set

#
# Frame-buffer support
#
CONFIG_FB=y
CONFIG_DUMMY_CONSOLE=y
# CONFIG_FB_RIVA is not set
# CONFIG_FB_CLGEN is not set
# CONFIG_FB_PM2 is not set
# CONFIG_FB_CYBER2000 is not set
# CONFIG_FB_VESA is not set
# CONFIG_FB_VGA16 is not set
# CONFIG_FB_HGA is not set
CONFIG_VIDEO_SELECT=y
# CONFIG_FB_MATROX is not set
# CONFIG_FB_ATY is not set
# CONFIG_FB_RADEON is not set
# CONFIG_FB_ATY128 is not set
CONFIG_FB_SIS=y
CONFIG_FB_SIS_300=y
# CONFIG_FB_SIS_315 is not set
# CONFIG_FB_3DFX is not set
# CONFIG_FB_VOODOO1 is not set
# CONFIG_FB_VIRTUAL is not set
# CONFIG_FBCON_ADVANCED is not set
CONFIG_FBCON_CFB8=y
CONFIG_FBCON_CFB16=y
CONFIG_FBCON_CFB32=y
# CONFIG_FBCON_FONTWIDTH8_ONLY is not set
# CONFIG_FBCON_FONTS is not set
CONFIG_FONT_8x8=y
CONFIG_FONT_8x16=y

#
# Sound
#
CONFIG_SOUND=y
# CONFIG_SOUND_BT878 is not set
CONFIG_SOUND_CMPCI=m
# CONFIG_SOUND_CMPCI_FM is not set
# CONFIG_SOUND_CMPCI_MIDI is not set
CONFIG_SOUND_CMPCI_JOYSTICK=y
CONFIG_SOUND_CMPCI_CM8738=y
# CONFIG_SOUND_CMPCI_SPDIFINVERSE is not set
# CONFIG_SOUND_CMPCI_SPDIFLOOP is not set
CONFIG_SOUND_CMPCI_SPEAKERS=2
# CONFIG_SOUND_EMU10K1 is not set
# CONFIG_MIDI_EMU10K1 is not set
# CONFIG_SOUND_FUSION is not set
# CONFIG_SOUND_CS4281 is not set
# CONFIG_SOUND_ES1370 is not set
# CONFIG_SOUND_ES1371 is not set
# CONFIG_SOUND_ESSSOLO1 is not set
# CONFIG_SOUND_MAESTRO is not set
# CONFIG_SOUND_MAESTRO3 is not set
# CONFIG_SOUND_ICH is not set
# CONFIG_SOUND_RME96XX is not set
# CONFIG_SOUND_SONICVIBES is not set
# CONFIG_SOUND_TRIDENT is not set
# CONFIG_SOUND_MSNDCLAS is not set
# CONFIG_SOUND_MSNDPIN is not set
# CONFIG_SOUND_VIA82CXXX is not set
# CONFIG_MIDI_VIA82CXXX is not set
# CONFIG_SOUND_OSS is not set
# CONFIG_SOUND_TVMIXER is not set

#
# USB support
#
CONFIG_USB=y
# CONFIG_USB_DEBUG is not set

#
# Miscellaneous USB options
#
CONFIG_USB_DEVICEFS=y
# CONFIG_USB_BANDWIDTH is not set
# CONFIG_USB_LONG_TIMEOUT is not set

#
# USB Host Controller Drivers
#
CONFIG_USB_EHCI_HCD=m
CONFIG_USB_UHCI=m
CONFIG_USB_UHCI_ALT=m
CONFIG_USB_OHCI=m

#
# USB Device Class drivers
#
CONFIG_USB_AUDIO=m
# CONFIG_USB_BLUETOOTH is not set
CONFIG_USB_STORAGE=m
# CONFIG_USB_STORAGE_DEBUG is not set
# CONFIG_USB_STORAGE_DATAFAB is not set
# CONFIG_USB_STORAGE_FREECOM is not set
# CONFIG_USB_STORAGE_ISD200 is not set
CONFIG_USB_STORAGE_DPCM=y
# CONFIG_USB_STORAGE_HP8200e is not set
CONFIG_USB_STORAGE_SDDR09=y
# CONFIG_USB_STORAGE_JUMPSHOT is not set
# CONFIG_USB_ACM is not set
CONFIG_USB_PRINTER=m

#
# USB Human Interface Devices (HID)
#
CONFIG_USB_HID=m
# CONFIG_USB_HIDDEV is not set
CONFIG_USB_KBD=m
CONFIG_USB_MOUSE=m
# CONFIG_USB_WACOM is not set

#
# USB Imaging devices
#
# CONFIG_USB_DC2XX is not set
# CONFIG_USB_MDC800 is not set
CONFIG_USB_SCANNER=m
# CONFIG_USB_MICROTEK is not set
# CONFIG_USB_HPUSBSCSI is not set

#
# USB Multimedia devices
#

#
#   Video4Linux support is needed for USB Multimedia device support
#

#
# USB Network adaptors
#
# CONFIG_USB_PEGASUS is not set
# CONFIG_USB_KAWETH is not set
# CONFIG_USB_CATC is not set
# CONFIG_USB_CDCETHER is not set
# CONFIG_USB_USBNET is not set

#
# USB port drivers
#
# CONFIG_USB_USS720 is not set

#
# USB Serial Converter support
#
# CONFIG_USB_SERIAL is not set
# CONFIG_USB_SERIAL_GENERIC is not set
# CONFIG_USB_SERIAL_BELKIN is not set
# CONFIG_USB_SERIAL_WHITEHEAT is not set
# CONFIG_USB_SERIAL_DIGI_ACCELEPORT is not set
# CONFIG_USB_SERIAL_EMPEG is not set
# CONFIG_USB_SERIAL_FTDI_SIO is not set
# CONFIG_USB_SERIAL_VISOR is not set
# CONFIG_USB_SERIAL_IPAQ is not set
# CONFIG_USB_SERIAL_IR is not set
# CONFIG_USB_SERIAL_EDGEPORT is not set
# CONFIG_USB_SERIAL_KEYSPAN_PDA is not set
# CONFIG_USB_SERIAL_KEYSPAN is not set
# CONFIG_USB_SERIAL_KEYSPAN_USA28 is not set
# CONFIG_USB_SERIAL_KEYSPAN_USA28X is not set
# CONFIG_USB_SERIAL_KEYSPAN_USA28XA is not set
# CONFIG_USB_SERIAL_KEYSPAN_USA28XB is not set
# CONFIG_USB_SERIAL_KEYSPAN_USA19 is not set
# CONFIG_USB_SERIAL_KEYSPAN_USA18X is not set
# CONFIG_USB_SERIAL_KEYSPAN_USA19W is not set
# CONFIG_USB_SERIAL_KEYSPAN_USA49W is not set
# CONFIG_USB_SERIAL_MCT_U232 is not set
# CONFIG_USB_SERIAL_KLSI is not set
# CONFIG_USB_SERIAL_PL2303 is not set
# CONFIG_USB_SERIAL_CYBERJACK is not set
# CONFIG_USB_SERIAL_XIRCOM is not set
# CONFIG_USB_SERIAL_OMNINET is not set

#
# USB Miscellaneous drivers
#
# CONFIG_USB_RIO500 is not set
# CONFIG_USB_AUERSWALD is not set

#
# Bluetooth support
#
# CONFIG_BLUEZ is not set

#
# Kernel hacking
#
CONFIG_DEBUG_KERNEL=y
# CONFIG_DEBUG_HIGHMEM is not set
CONFIG_DEBUG_SLAB=y
CONFIG_DEBUG_IOVIRT=y
CONFIG_MAGIC_SYSRQ=y
# CONFIG_DEBUG_SPINLOCK is not set
CONFIG_DEBUG_BUGVERBOSE=y
# CONFIG_DEBUG_486_STRING is not set

#
# Library routines
#
CONFIG_CRC32=y

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: depmod problem for 2.5.2-dj4
  2002-01-23  0:12 depmod problem for 2.5.2-dj4 Torrey Hoffman
@ 2002-01-23  4:54 ` Greg KH
  2002-01-23  8:44   ` Vojtech Pavlik
  0 siblings, 1 reply; 12+ messages in thread
From: Greg KH @ 2002-01-23  4:54 UTC (permalink / raw)
  To: Torrey Hoffman, vojtech; +Cc: Linux Kernel

On Tue, Jan 22, 2002 at 04:12:30PM -0800, Torrey Hoffman wrote:
> 
> depmod: *** Unresolved symbols in
> /lib/modules/2.5.2-dj4/kernel/drivers/usb/hid.o
> depmod: 	usb_make_path
> depmod: *** Unresolved symbols in
> /lib/modules/2.5.2-dj4/kernel/drivers/usb/usbkbd.o
> depmod: 	usb_make_path
> depmod: *** Unresolved symbols in
> /lib/modules/2.5.2-dj4/kernel/drivers/usb/usbmouse.o
> depmod: 	usb_make_path
> make: *** [_modinst_post] Error 1

Looks like you need to add a:
	EXPORT_SYMBOL(usb_make_path);
to the usb.c file.

Vojtech, is this a USB function that you want added to usb.c?
Didn't you (or someone else) propose a function like this in the past?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: depmod problem for 2.5.2-dj4
  2002-01-23  4:54 ` Greg KH
@ 2002-01-23  8:44   ` Vojtech Pavlik
  2002-01-23 21:24     ` Greg KH
  0 siblings, 1 reply; 12+ messages in thread
From: Vojtech Pavlik @ 2002-01-23  8:44 UTC (permalink / raw)
  To: Greg KH; +Cc: Torrey Hoffman, vojtech, Linux Kernel

On Tue, Jan 22, 2002 at 08:54:05PM -0800, Greg KH wrote:
> On Tue, Jan 22, 2002 at 04:12:30PM -0800, Torrey Hoffman wrote:
> > 
> > depmod: *** Unresolved symbols in
> > /lib/modules/2.5.2-dj4/kernel/drivers/usb/hid.o
> > depmod: 	usb_make_path
> > depmod: *** Unresolved symbols in
> > /lib/modules/2.5.2-dj4/kernel/drivers/usb/usbkbd.o
> > depmod: 	usb_make_path
> > depmod: *** Unresolved symbols in
> > /lib/modules/2.5.2-dj4/kernel/drivers/usb/usbmouse.o
> > depmod: 	usb_make_path
> > make: *** [_modinst_post] Error 1
> 
> Looks like you need to add a:
> 	EXPORT_SYMBOL(usb_make_path);
> to the usb.c file.

Correct.

> Vojtech, is this a USB function that you want added to usb.c?

Yes, please. This will change later when Pat Mochels devicefs kicks in,
but for the time being, it'd be very useful.

> Didn't you (or someone else) propose a function like this in the past?

I'm not sure, I may have proposed it. I'm not sure of the outcome
either. The input subsystem needs to use the bus topology for matching
the devices - there is no other way to differentiate between two
identical USB mice.

Do you think it could be added?

-- 
Vojtech Pavlik
SuSE Labs

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: depmod problem for 2.5.2-dj4
  2002-01-23  8:44   ` Vojtech Pavlik
@ 2002-01-23 21:24     ` Greg KH
  2002-01-23 22:22       ` Greg KH
  2002-01-24  0:46       ` [linux-usb-devel] " David Brownell
  0 siblings, 2 replies; 12+ messages in thread
From: Greg KH @ 2002-01-23 21:24 UTC (permalink / raw)
  To: Vojtech Pavlik; +Cc: Torrey Hoffman, vojtech, Linux Kernel, linux-usb-devel

On Wed, Jan 23, 2002 at 09:44:14AM +0100, Vojtech Pavlik wrote:
> On Tue, Jan 22, 2002 at 08:54:05PM -0800, Greg KH wrote:
> > Vojtech, is this a USB function that you want added to usb.c?
> 
> Yes, please. This will change later when Pat Mochels devicefs kicks in,
> but for the time being, it'd be very useful.

Here's a patch against 2.5.3-pre3, does it look ok to you (I fixed the
potential memory leak in the second kmalloc call from what was in
2.5.2-dj4)?

greg k-h

diff -Nru a/drivers/usb/usb.c b/drivers/usb/usb.c
--- a/drivers/usb/usb.c	Wed Jan 23 13:20:28 2002
+++ b/drivers/usb/usb.c	Wed Jan 23 13:20:28 2002
@@ -2513,6 +2513,49 @@
 	return err;
 }
 
+/**
+ * usb_make_path - returns device path in the hub tree
+ * @dev: the device whose path is being constructed
+ * @buf: where to put the string
+ * @size: how big is "buf"?
+ *
+ * Returns length of the string (>= 0) or out of memory status (< 0).
+ */
+int usb_make_path(struct usb_device *dev, char *buf, size_t size)
+{
+	struct usb_device *pdev = dev->parent;
+	char *tmp;
+	char *port;
+	int i;
+
+	if (!(port = kmalloc(size, GFP_KERNEL)))
+		return -ENOMEM;
+	if (!(tmp = kmalloc(size, GFP_KERNEL))) {
+		kfree(port);
+		return -ENOMEM;
+	}
+
+	*port = 0;
+
+	while (pdev) {
+		for (i = 0; i < pdev->maxchild; i++)
+			if (pdev->children[i] == dev)
+				break;
+
+		if (pdev->children[i] != dev)
+			return -1;
+
+		strcpy(tmp, port);
+		snprintf(port, size, strlen(port) ? "%d.%s" : "%d", i + 1, tmp);
+
+		dev = pdev;
+		pdev = dev->parent;
+	}
+
+	snprintf(buf, size, "usb%d:%s", dev->bus->busnum, port);
+	return strlen(buf);
+}
+
 /*
  * By the time we get here, the device has gotten a new device ID
  * and is in the default state. We need to identify the thing and
@@ -2762,5 +2805,6 @@
 EXPORT_SYMBOL(usb_set_configuration);
 EXPORT_SYMBOL(usb_set_interface);
 
+EXPORT_SYMBOL(usb_make_path);
 EXPORT_SYMBOL(usb_devfs_handle);
 MODULE_LICENSE("GPL");
diff -Nru a/include/linux/usb.h b/include/linux/usb.h
--- a/include/linux/usb.h	Wed Jan 23 13:20:28 2002
+++ b/include/linux/usb.h	Wed Jan 23 13:20:28 2002
@@ -881,6 +881,7 @@
 	char *buf, size_t size);
 extern int usb_set_configuration(struct usb_device *dev, int configuration);
 extern int usb_set_interface(struct usb_device *dev, int ifnum, int alternate);
+extern int usb_make_path(struct usb_device *dev, char *buf, size_t size);
 
 /*
  * timeouts, in seconds, used for sending/receiving control messages

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: depmod problem for 2.5.2-dj4
  2002-01-23 21:24     ` Greg KH
@ 2002-01-23 22:22       ` Greg KH
  2002-01-23 22:47         ` Vojtech Pavlik
  2002-01-24  0:46       ` [linux-usb-devel] " David Brownell
  1 sibling, 1 reply; 12+ messages in thread
From: Greg KH @ 2002-01-23 22:22 UTC (permalink / raw)
  To: Vojtech Pavlik; +Cc: Torrey Hoffman, vojtech, Linux Kernel, linux-usb-devel

On Wed, Jan 23, 2002 at 01:24:36PM -0800, Greg KH wrote:
> On Wed, Jan 23, 2002 at 09:44:14AM +0100, Vojtech Pavlik wrote:
> > On Tue, Jan 22, 2002 at 08:54:05PM -0800, Greg KH wrote:
> > > Vojtech, is this a USB function that you want added to usb.c?
> > 
> > Yes, please. This will change later when Pat Mochels devicefs kicks in,
> > but for the time being, it'd be very useful.
> 
> Here's a patch against 2.5.3-pre3, does it look ok to you (I fixed the
> potential memory leak in the second kmalloc call from what was in
> 2.5.2-dj4)?

Oops, more memory leak fixes:

> diff -Nru a/drivers/usb/usb.c b/drivers/usb/usb.c
> --- a/drivers/usb/usb.c	Wed Jan 23 13:20:28 2002
> +++ b/drivers/usb/usb.c	Wed Jan 23 13:20:28 2002
> @@ -2513,6 +2513,49 @@
>  	return err;
>  }
>  
> +/**
> + * usb_make_path - returns device path in the hub tree
> + * @dev: the device whose path is being constructed
> + * @buf: where to put the string
> + * @size: how big is "buf"?
> + *
> + * Returns length of the string (>= 0) or out of memory status (< 0).
> + */
> +int usb_make_path(struct usb_device *dev, char *buf, size_t size)
> +{
> +	struct usb_device *pdev = dev->parent;
> +	char *tmp;
> +	char *port;
> +	int i;
> +
> +	if (!(port = kmalloc(size, GFP_KERNEL)))
> +		return -ENOMEM;
> +	if (!(tmp = kmalloc(size, GFP_KERNEL))) {
> +		kfree(port);
> +		return -ENOMEM;
> +	}
> +
> +	*port = 0;
> +
> +	while (pdev) {
> +		for (i = 0; i < pdev->maxchild; i++)
> +			if (pdev->children[i] == dev)
> +				break;
> +
> +		if (pdev->children[i] != dev)
> +			return -1;

Should be:
		if (pdev->children[i] != dev) {
			kfree(port);
			kfree(tmp);
			return -ENODEV;
		}

> +
> +		strcpy(tmp, port);
> +		snprintf(port, size, strlen(port) ? "%d.%s" : "%d", i + 1, tmp);
> +
> +		dev = pdev;
> +		pdev = dev->parent;
> +	}
> +
> +	snprintf(buf, size, "usb%d:%s", dev->bus->busnum, port);

And add:
	kfree(port);
	kfree(tmp);

> +	return strlen(buf);
> +}


Does that look better?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: depmod problem for 2.5.2-dj4
  2002-01-23 22:22       ` Greg KH
@ 2002-01-23 22:47         ` Vojtech Pavlik
  2002-01-23 23:00           ` Greg KH
  0 siblings, 1 reply; 12+ messages in thread
From: Vojtech Pavlik @ 2002-01-23 22:47 UTC (permalink / raw)
  To: Greg KH; +Cc: Torrey Hoffman, vojtech, Linux Kernel, linux-usb-devel

On Wed, Jan 23, 2002 at 02:22:51PM -0800, Greg KH wrote:
> On Wed, Jan 23, 2002 at 01:24:36PM -0800, Greg KH wrote:
> > On Wed, Jan 23, 2002 at 09:44:14AM +0100, Vojtech Pavlik wrote:
> > > On Tue, Jan 22, 2002 at 08:54:05PM -0800, Greg KH wrote:
> > > > Vojtech, is this a USB function that you want added to usb.c?
> > > 
> > > Yes, please. This will change later when Pat Mochels devicefs kicks in,
> > > but for the time being, it'd be very useful.
> > 
> > Here's a patch against 2.5.3-pre3, does it look ok to you (I fixed the
> > potential memory leak in the second kmalloc call from what was in
> > 2.5.2-dj4)?

Yes, this is perfect. *shiver* I can't believe I made the code so leaky.
Sorry for that, it's a copy-paste problem.
Thanks for fixing it.

> Oops, more memory leak fixes:
> 
> > diff -Nru a/drivers/usb/usb.c b/drivers/usb/usb.c
> > --- a/drivers/usb/usb.c	Wed Jan 23 13:20:28 2002
> > +++ b/drivers/usb/usb.c	Wed Jan 23 13:20:28 2002
> > @@ -2513,6 +2513,49 @@
> >  	return err;
> >  }
> >  
> > +/**
> > + * usb_make_path - returns device path in the hub tree
> > + * @dev: the device whose path is being constructed
> > + * @buf: where to put the string
> > + * @size: how big is "buf"?
> > + *
> > + * Returns length of the string (>= 0) or out of memory status (< 0).
> > + */
> > +int usb_make_path(struct usb_device *dev, char *buf, size_t size)
> > +{
> > +	struct usb_device *pdev = dev->parent;
> > +	char *tmp;
> > +	char *port;
> > +	int i;
> > +
> > +	if (!(port = kmalloc(size, GFP_KERNEL)))
> > +		return -ENOMEM;
> > +	if (!(tmp = kmalloc(size, GFP_KERNEL))) {
> > +		kfree(port);
> > +		return -ENOMEM;
> > +	}
> > +
> > +	*port = 0;
> > +
> > +	while (pdev) {
> > +		for (i = 0; i < pdev->maxchild; i++)
> > +			if (pdev->children[i] == dev)
> > +				break;
> > +
> > +		if (pdev->children[i] != dev)
> > +			return -1;
> 
> Should be:
> 		if (pdev->children[i] != dev) {
> 			kfree(port);
> 			kfree(tmp);
> 			return -ENODEV;
> 		}
> 
> > +
> > +		strcpy(tmp, port);
> > +		snprintf(port, size, strlen(port) ? "%d.%s" : "%d", i + 1, tmp);
> > +
> > +		dev = pdev;
> > +		pdev = dev->parent;
> > +	}
> > +
> > +	snprintf(buf, size, "usb%d:%s", dev->bus->busnum, port);
> 
> And add:
> 	kfree(port);
> 	kfree(tmp);
> 
> > +	return strlen(buf);
> > +}
> 
> 
> Does that look better?
> 
> thanks,
> 
> greg k-h

-- 
Vojtech Pavlik
SuSE Labs

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: depmod problem for 2.5.2-dj4
  2002-01-23 22:47         ` Vojtech Pavlik
@ 2002-01-23 23:00           ` Greg KH
  0 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2002-01-23 23:00 UTC (permalink / raw)
  To: Vojtech Pavlik; +Cc: Linux Kernel, linux-usb-devel

On Wed, Jan 23, 2002 at 11:47:14PM +0100, Vojtech Pavlik wrote:
> 
> Yes, this is perfect. *shiver* I can't believe I made the code so leaky.
> Sorry for that, it's a copy-paste problem.
> Thanks for fixing it.

No problem, I'll send it out in my next round of patches.

greg k-h

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [linux-usb-devel] Re: depmod problem for 2.5.2-dj4
  2002-01-23 21:24     ` Greg KH
  2002-01-23 22:22       ` Greg KH
@ 2002-01-24  0:46       ` David Brownell
  2002-01-24  9:01         ` Vojtech Pavlik
  1 sibling, 1 reply; 12+ messages in thread
From: David Brownell @ 2002-01-24  0:46 UTC (permalink / raw)
  To: Greg KH, Vojtech Pavlik; +Cc: Torrey Hoffman, Linux Kernel, linux-usb-devel

> > > Vojtech, is this a USB function that you want added to usb.c?
> > 
> > Yes, please. This will change later when Pat Mochels devicefs kicks in,

What's the story on "driverfs" happening, by the way?  Last I knew, the
PCI bits weren't yet ready.


> > but for the time being, it'd be very useful.
>
> +int usb_make_path(struct usb_device *dev, char *buf, size_t size)

I don't think that patch is necessary.  It's simpler to just

    strncpy (buf, dev->devpath, min_t(size_t, size, sizeof dev->devpath));

Use like you'd use pci_dev->slot_name ... no mallocation necessary.
It's just the path from root hub down to device, /2/1/7 and so on:  the
physical path, which stays the same so long as you don't recable your
tree of USB devices and hubs.

I'd expect the typical "driverfs" path for a USB device to be the
path for the root hub (normally a PCI slot like 00:0f.3) followed by
what "devpath" now shows.

- Dave




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [linux-usb-devel] Re: depmod problem for 2.5.2-dj4
  2002-01-24  0:46       ` [linux-usb-devel] " David Brownell
@ 2002-01-24  9:01         ` Vojtech Pavlik
  2002-01-24  9:20           ` Dave Jones
  2002-01-24 15:27           ` [linux-usb-devel] Re: usb+driverfs [was depmod problem for 2.5.2-dj4] David Brownell
  0 siblings, 2 replies; 12+ messages in thread
From: Vojtech Pavlik @ 2002-01-24  9:01 UTC (permalink / raw)
  To: David Brownell; +Cc: Greg KH, Torrey Hoffman, Linux Kernel, linux-usb-devel

On Wed, Jan 23, 2002 at 04:46:13PM -0800, David Brownell wrote:
> > > > Vojtech, is this a USB function that you want added to usb.c?
> > > 
> > > Yes, please. This will change later when Pat Mochels devicefs kicks in,
> 
> What's the story on "driverfs" happening, by the way?  Last I knew, the
> PCI bits weren't yet ready.

I'm not absolutely sure about the status of the PCI support, but it
should be close to working. Anyway, the driverfs infrastructure itself
is in place in 2.5, so even if the PCI part wasn't there, still we can
convert USB and Input to it.

> > > but for the time being, it'd be very useful.
> >
> > +int usb_make_path(struct usb_device *dev, char *buf, size_t size)
> 
> I don't think that patch is necessary.  It's simpler to just
> 
>     strncpy (buf, dev->devpath, min_t(size_t, size, sizeof dev->devpath));
> 
> Use like you'd use pci_dev->slot_name ... no mallocation necessary.
> It's just the path from root hub down to device, /2/1/7 and so on:  the
> physical path, which stays the same so long as you don't recable your
> tree of USB devices and hubs.
> 
> I'd expect the typical "driverfs" path for a USB device to be the
> path for the root hub (normally a PCI slot like 00:0f.3) followed by
> what "devpath" now shows.

Ahh, I see. This "devpath" entry wasn't available at the time I wrote
the 'usb_make_path' function. This is of course much better. What's not
very convenient for me right now is that it uses slashes instead of
dots, which the input subsystem uses for delimiting busses from each
other, like:

isa0060/serio0/input0 - AT keyboard
pci0:7.3/usb1:2.2/input0 - USB keboard

Using slashes in place of the dots would make it quite a mess. The
slashes are probably there because of usbdevfs, right?

Note that the PCI "slot_name" doesn't use slashes ...

-- 
Vojtech Pavlik
SuSE Labs

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [linux-usb-devel] Re: depmod problem for 2.5.2-dj4
  2002-01-24  9:01         ` Vojtech Pavlik
@ 2002-01-24  9:20           ` Dave Jones
  2002-01-24 15:27           ` [linux-usb-devel] Re: usb+driverfs [was depmod problem for 2.5.2-dj4] David Brownell
  1 sibling, 0 replies; 12+ messages in thread
From: Dave Jones @ 2002-01-24  9:20 UTC (permalink / raw)
  To: Vojtech Pavlik
  Cc: David Brownell, Greg KH, Torrey Hoffman, Linux Kernel,
	linux-usb-devel

On Thu, Jan 24, 2002 at 10:01:54AM +0100, Vojtech Pavlik wrote:
 
 > > What's the story on "driverfs" happening, by the way?  Last I knew, the
 > > PCI bits weren't yet ready.
 > I'm not absolutely sure about the status of the PCI support, but it
 > should be close to working. Anyway, the driverfs infrastructure itself
 > is in place in 2.5, so even if the PCI part wasn't there, still we can
 > convert USB and Input to it.

>From pre4 changelog:
- Patrick Mochel: devicefs updates, add PCI devices into the hierarchy
 
-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [linux-usb-devel] Re: usb+driverfs [was depmod problem for 2.5.2-dj4]
  2002-01-24  9:01         ` Vojtech Pavlik
  2002-01-24  9:20           ` Dave Jones
@ 2002-01-24 15:27           ` David Brownell
  2002-01-24 15:32             ` Vojtech Pavlik
  1 sibling, 1 reply; 12+ messages in thread
From: David Brownell @ 2002-01-24 15:27 UTC (permalink / raw)
  To: Vojtech Pavlik; +Cc: Greg KH, Torrey Hoffman, Linux Kernel, linux-usb-devel

Quoth "Vojtech Pavlik" <vojtech@suse.cz>:
> On Wed, Jan 23, 2002 at 04:46:13PM -0800, David Brownell wrote:
> > What's the story on "driverfs" happening, by the way?  Last I knew, the
> > PCI bits weren't yet ready.
> 
> I'm not absolutely sure about the status of the PCI support, but it
> should be close to working. Anyway, the driverfs infrastructure itself
> is in place in 2.5, so even if the PCI part wasn't there, still we can
> convert USB and Input to it.

Since all the USB HCDs use PCI, I think the 2.5.3-pre4 updates
(well timed :) are necessary to convert USB:  HCDs first, then the
hub driver, then input.   Or at least, that's how I understand things
right now -- I was waiting for a "finished" example to read! :)


> >     strncpy (buf, dev->devpath, min_t(size_t, size, sizeof dev->devpath));
> > 
> > Use like you'd use pci_dev->slot_name ... no mallocation necessary.
> > It's just the path from root hub down to device, /2/1/7 and so on:  the
> > physical path, which stays the same so long as you don't recable your
> > tree of USB devices and hubs.
> > 
> > I'd expect the typical "driverfs" path for a USB device to be the
> > path for the root hub (normally a PCI slot like 00:0f.3) followed by
> > what "devpath" now shows.
> 
> Ahh, I see. This "devpath" entry wasn't available at the time I wrote
> the 'usb_make_path' function. This is of course much better. What's not
> very convenient for me right now is that it uses slashes instead of
> dots, which the input subsystem uses for delimiting busses from each
> other, like:
> 
> isa0060/serio0/input0 - AT keyboard
> pci0:7.3/usb1:2.2/input0 - USB keboard
> 
> Using slashes in place of the dots would make it quite a mess. The
> slashes are probably there because of usbdevfs, right?

Driverfs -- since the hubs are part of the device hierarchy,
which shows up in the filesystem.  Also that's what the code
it replaced did (in the hub driver).  Maybe it should change
to use driverfs directly... :)

- Dave


> Note that the PCI "slot_name" doesn't use slashes ...
> 
> -- 
> Vojtech Pavlik
> SuSE Labs


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [linux-usb-devel] Re: usb+driverfs [was depmod problem for 2.5.2-dj4]
  2002-01-24 15:27           ` [linux-usb-devel] Re: usb+driverfs [was depmod problem for 2.5.2-dj4] David Brownell
@ 2002-01-24 15:32             ` Vojtech Pavlik
  0 siblings, 0 replies; 12+ messages in thread
From: Vojtech Pavlik @ 2002-01-24 15:32 UTC (permalink / raw)
  To: David Brownell; +Cc: Greg KH, Torrey Hoffman, Linux Kernel, linux-usb-devel

On Thu, Jan 24, 2002 at 07:27:41AM -0800, David Brownell wrote:
> Quoth "Vojtech Pavlik" <vojtech@suse.cz>:
> > On Wed, Jan 23, 2002 at 04:46:13PM -0800, David Brownell wrote:
> > > What's the story on "driverfs" happening, by the way?  Last I knew, the
> > > PCI bits weren't yet ready.
> > 
> > I'm not absolutely sure about the status of the PCI support, but it
> > should be close to working. Anyway, the driverfs infrastructure itself
> > is in place in 2.5, so even if the PCI part wasn't there, still we can
> > convert USB and Input to it.
> 
> Since all the USB HCDs use PCI, I think the 2.5.3-pre4 updates
> (well timed :) are necessary to convert USB:  HCDs first, then the
> hub driver, then input.   Or at least, that's how I understand things
> right now -- I was waiting for a "finished" example to read! :)

> > >     strncpy (buf, dev->devpath, min_t(size_t, size, sizeof dev->devpath));
> > > 
> > > Use like you'd use pci_dev->slot_name ... no mallocation necessary.
> > > It's just the path from root hub down to device, /2/1/7 and so on:  the
> > > physical path, which stays the same so long as you don't recable your
> > > tree of USB devices and hubs.
> > > 
> > > I'd expect the typical "driverfs" path for a USB device to be the
> > > path for the root hub (normally a PCI slot like 00:0f.3) followed by
> > > what "devpath" now shows.
> > 
> > Ahh, I see. This "devpath" entry wasn't available at the time I wrote
> > the 'usb_make_path' function. This is of course much better. What's not
> > very convenient for me right now is that it uses slashes instead of
> > dots, which the input subsystem uses for delimiting busses from each
> > other, like:
> > 
> > isa0060/serio0/input0 - AT keyboard
> > pci0:7.3/usb1:2.2/input0 - USB keboard
> > 
> > Using slashes in place of the dots would make it quite a mess. The
> > slashes are probably there because of usbdevfs, right?
> 
> Driverfs -- since the hubs are part of the device hierarchy,
> which shows up in the filesystem.  Also that's what the code
> it replaced did (in the hub driver).  Maybe it should change
> to use driverfs directly... :)

Ok, now that we have driverfs PCI in place, I'll keep usb_make_path for
a while not to break input, and once both hcds and hubs are converted,
I'll convert input. 

-- 
Vojtech Pavlik
SuSE Labs

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2002-01-24 15:33 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-01-23  0:12 depmod problem for 2.5.2-dj4 Torrey Hoffman
2002-01-23  4:54 ` Greg KH
2002-01-23  8:44   ` Vojtech Pavlik
2002-01-23 21:24     ` Greg KH
2002-01-23 22:22       ` Greg KH
2002-01-23 22:47         ` Vojtech Pavlik
2002-01-23 23:00           ` Greg KH
2002-01-24  0:46       ` [linux-usb-devel] " David Brownell
2002-01-24  9:01         ` Vojtech Pavlik
2002-01-24  9:20           ` Dave Jones
2002-01-24 15:27           ` [linux-usb-devel] Re: usb+driverfs [was depmod problem for 2.5.2-dj4] David Brownell
2002-01-24 15:32             ` Vojtech Pavlik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox