* 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return
@ 2002-01-23 7:34 Miles Lane
2002-01-23 7:45 ` Evgeniy Polyakov
0 siblings, 1 reply; 5+ messages in thread
From: Miles Lane @ 2002-01-23 7:34 UTC (permalink / raw)
To: LKML
make[2]: Entering directory `/usr/src/linux/drivers/net'
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DEXPORT_SYMTAB -c aironet4500_core.c
aironet4500_core.c: In function `awc_init':
aironet4500_core.c:2839: incompatible types in return
aironet4500_core.c:2841: warning: control reaches end of non-void function
make[2]: *** [aironet4500_core.o] Error 1
CONFIG_NET_PCMCIA=y
CONFIG_PCMCIA_3C589=m
CONFIG_PCMCIA_3C574=m
CONFIG_PCMCIA_FMVJ18X=m
CONFIG_PCMCIA_PCNET=y
CONFIG_PCMCIA_NMCLAN=m
CONFIG_PCMCIA_SMC91C92=m
CONFIG_PCMCIA_XIRC2PS=m
CONFIG_PCMCIA_AXNET=m
CONFIG_PCMCIA_XIRCOM=m
CONFIG_PCMCIA_XIRTULIP=m
CONFIG_NET_PCMCIA_RADIO=y
CONFIG_PCMCIA_RAYCS=y
CONFIG_AIRONET4500_CS=m
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return
2002-01-23 7:34 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return Miles Lane
@ 2002-01-23 7:45 ` Evgeniy Polyakov
2002-01-23 13:00 ` Dave Jones
0 siblings, 1 reply; 5+ messages in thread
From: Evgeniy Polyakov @ 2002-01-23 7:45 UTC (permalink / raw)
To: Miles Lane; +Cc: linux-kernel
On 22 Jan 2002 23:34:08 -0800
Miles Lane <miles@megapathdsl.net> wrote:
>
> make[2]: Entering directory `/usr/src/linux/drivers/net'
> gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE
> -DEXPORT_SYMTAB -c aironet4500_core.c aironet4500_core.c: In function
> `awc_init': aironet4500_core.c:2839: incompatible types in return
> aironet4500_core.c:2841: warning: control reaches end of non-void
> function make[2]: *** [aironet4500_core.o] Error 1
Try this patch, but it is given WITHOUT ANY WARRANTY.
I even cann't test to compile it.
And there is not ieee card here.
So, it was wrote with luck and common sense.
I hope it will help you.
P.S. If this is full bullshit... then i apologize and go learning Linux
kernel again...
--- ./drivers/net/aironet4500_core.c~ Sun Sep 30 23:26:06 2001
+++ ./drivers/net/aironet4500_core.c Wed Jan 23 10:44:03 2002
@@ -2836,7 +2836,7 @@
return 0;
final:
printk(KERN_ERR "aironet init failed \n");
- return NODEV;
+ return -1;
};
Evgeniy Polyakov ( s0mbre ).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return
2002-01-23 7:45 ` Evgeniy Polyakov
@ 2002-01-23 13:00 ` Dave Jones
2002-01-23 18:02 ` Evgeniy Polyakov
0 siblings, 1 reply; 5+ messages in thread
From: Dave Jones @ 2002-01-23 13:00 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: Miles Lane, linux-kernel
On Wed, Jan 23, 2002 at 10:45:50AM +0300, Evgeniy Polyakov wrote:
> --- ./drivers/net/aironet4500_core.c~ Sun Sep 30 23:26:06 2001
> +++ ./drivers/net/aironet4500_core.c Wed Jan 23 10:44:03 2002
> @@ -2836,7 +2836,7 @@
> return 0;
> final:
> printk(KERN_ERR "aironet init failed \n");
> - return NODEV;
> + return -1;
This should probably be return -ENODEV
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return
2002-01-23 13:00 ` Dave Jones
@ 2002-01-23 18:02 ` Evgeniy Polyakov
2002-01-25 2:57 ` Evgeniy Polyakov
0 siblings, 1 reply; 5+ messages in thread
From: Evgeniy Polyakov @ 2002-01-23 18:02 UTC (permalink / raw)
To: Dave Jones; +Cc: miles, linux-kernel
On Wed, 23 Jan 2002 14:00:44 +0100
Dave Jones <davej@suse.de> wrote:
> > - return NODEV;
> > + return -1;
> This should probably be return -ENODEV
It sould be negative integer.
kdev_val(NODEV) == 0, so it will indicate successive finish, that is not
right.
> --
> | Dave Jones. http://www.codemonkey.org.uk
> | SuSE Labs
Evgeniy Polyakov ( s0mbre ).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return
2002-01-23 18:02 ` Evgeniy Polyakov
@ 2002-01-25 2:57 ` Evgeniy Polyakov
0 siblings, 0 replies; 5+ messages in thread
From: Evgeniy Polyakov @ 2002-01-25 2:57 UTC (permalink / raw)
To: davej; +Cc: linux-kernel
On Wed, 23 Jan 2002 21:02:46 +0300
Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
> > > - return NODEV;
> > > + return -1;
>
> > This should probably be return -ENODEV
>
> It sould be negative integer.
> kdev_val(NODEV) == 0, so it will indicate successive finish, that is not
> right.
Ooops, sorry, this <censored> was written probably on drugs...
You absolutely right, and i didn't see 'E' letter in your mail.
Take my appologize.
> > --
> > | Dave Jones. http://www.codemonkey.org.uk
> > | SuSE Labs
Evgeniy Polyakov ( s0mbre ).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-01-25 2:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-01-23 7:34 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return Miles Lane
2002-01-23 7:45 ` Evgeniy Polyakov
2002-01-23 13:00 ` Dave Jones
2002-01-23 18:02 ` Evgeniy Polyakov
2002-01-25 2:57 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox