From: Jens Axboe <axboe@suse.de>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi uodate to remove io_request_lock
Date: Mon, 28 Jan 2002 10:08:04 +0100 [thread overview]
Message-ID: <20020128100804.A8894@suse.de> (raw)
In-Reply-To: <20020128073357.53c9569f.johnpol@2ka.mipt.ru>
In-Reply-To: <20020128073357.53c9569f.johnpol@2ka.mipt.ru>
On Mon, Jan 28 2002, Evgeniy Polyakov wrote:
> Hello, Jens Axboe, Linus Torvalds and other linux kernel hackers.
>
> Here is patch against 2.5.3-pre5 which removes io_request_lock.
You seem to be using &host->host_lock, which isn't quite right. SCSI
adapters pass down a preferred lock with scsi_assign_lock, and host_lock
_points_ to that lock. So you need to be using host->host_lock. A
compile should have caught this error (build SMP, of course).
> But unfortunnually here is 1 file (drivers/scsi/3w-xxxx.c),
> which still use spinning locks with io_request_lock because of detect()
> method, in which we cann't send Scsi_Host pointer. So this file must be
> corrected in some other way.
->detect() is not called with the lock held anymore...
> So, please check and apply.
You still have a bit of work to do :-)
--
Jens Axboe
next prev parent reply other threads:[~2002-01-28 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-28 4:33 [PATCH] scsi uodate to remove io_request_lock Evgeniy Polyakov
2002-01-28 9:08 ` Jens Axboe [this message]
[not found] <20020129043528.47f020a7.johnpol@2ka.mipt.ru>
2002-01-29 1:46 ` Linus Torvalds
2002-01-29 2:29 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020128100804.A8894@suse.de \
--to=axboe@suse.de \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox