From: Jens Axboe <axboe@suse.de>
To: Richard Gooch <rgooch@ras.ucalgary.ca>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sd-many for 2.4.18-pre7 (uses devfs)
Date: Mon, 28 Jan 2002 18:01:42 +0100 [thread overview]
Message-ID: <20020128180142.A5588@suse.de> (raw)
In-Reply-To: <200201280326.g0S3QTt27080@vindaloo.ras.ucalgary.ca> <20020128101035.B8894@suse.de> <200201281645.g0SGjZp02300@vindaloo.ras.ucalgary.ca>
In-Reply-To: <200201281645.g0SGjZp02300@vindaloo.ras.ucalgary.ca>
On Mon, Jan 28 2002, Richard Gooch wrote:
> Jens Axboe writes:
> > On Sun, Jan 27 2002, Richard Gooch wrote:
> > > Hi, all. Appended is my sd-many patch. It supports up to 2080
> > > SD's. This patch is against 2.4.18-pre7, and is essentially the same
> > > as earlier versions of this patch, just compensating for kernel drift.
> >
> > Could you please at least try to follow the style in sd? To me, this
> > alone is reason enough why the patch should not be applied.
>
> ??? I *have* followed the style. Or at least I've tried to. Where did
> I not?
Are you serious?! You use
if (condition) do_something
you use
#ifdef something
# define something_else
#endif
Your choice of style isn't even consistent throughout the patch...
Granted, SCSI isn't the most consistently styled stuff out there, but
lets not make it worse.
--
Jens Axboe
next prev parent reply other threads:[~2002-01-28 17:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-28 3:26 [PATCH] sd-many for 2.4.18-pre7 (uses devfs) Richard Gooch
2002-01-28 9:10 ` Jens Axboe
2002-01-28 16:45 ` Richard Gooch
2002-01-28 17:01 ` Jens Axboe [this message]
2002-01-28 17:25 ` Richard Gooch
2002-01-28 17:31 ` Jens Axboe
2002-01-28 17:35 ` Richard Gooch
2002-01-28 20:18 ` Daniel Phillips
2002-01-28 20:18 ` Jens Axboe
2002-01-28 20:36 ` Richard Gooch
2002-01-28 20:46 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020128180142.A5588@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rgooch@ras.ucalgary.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox