From: Pete Zaitcev <zaitcev@redhat.com>
To: Jesper Juhl <jju@dif.dk>
Cc: "'linux-kernel@vger.kernel.org '" <linux-kernel@vger.kernel.org>
Subject: Re: Encountered a Null Pointer Problem on the SCSI Layer
Date: Mon, 28 Jan 2002 19:05:51 -0500 [thread overview]
Message-ID: <20020128190551.A4236@devserv.devel.redhat.com> (raw)
In-Reply-To: <8A43C34093B3D5119F7D0004AC56F4BCC3448C@difpst1a.dif.dk>
In-Reply-To: <8A43C34093B3D5119F7D0004AC56F4BCC3448C@difpst1a.dif.dk>; from jju@dif.dk on Tue, Jan 29, 2002 at 12:57:02AM +0100
> From: Jesper Juhl <jju@dif.dk>
> Date: Tue, 29 Jan 2002 00:57:02 +0100
> > - if (!dpnt)
> > + if (!dpnt->device)
> > return NULL; /* No such device */
>
> Maybe I don't understand this right, but shouldn't that be
>
> if (!dpnt || !dpnt->device)
> return NULL; /* No such device */
In both cases, the code is like this:
dpnt = &rscsi_disks[dev_nr];
if (!dpnt->device)
return NULL;
So, it is unlikely that dpnt would be zero. It could be if rscsi_disks
were NULL, and in such case whole logics is toast.
-- Pete
next parent reply other threads:[~2002-01-29 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8A43C34093B3D5119F7D0004AC56F4BCC3448C@difpst1a.dif.dk>
2002-01-29 0:05 ` Pete Zaitcev [this message]
2002-01-29 15:03 Encountered a Null Pointer Problem on the SCSI Layer Peter Wong
[not found] <mailman.1012257244.13523.linux-kernel2news@redhat.com>
2002-01-28 23:17 ` Pete Zaitcev
2002-01-29 3:51 ` David Ford
2002-01-29 17:22 ` Horst von Brand
-- strict thread matches above, loose matches on Subject: below --
2002-01-28 22:30 Peter Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020128190551.A4236@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=jju@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox