From: "David S. Miller" <davem@redhat.com>
To: garzik@havoc.gtf.org
Cc: alan@lxorguk.ukuu.org.uk, vandrove@vc.cvut.cz,
torvalds@transmeta.com, linux-kernel@vger.kernel.org,
paulus@samba.org, davidm@hpl.hp.com, ralf@gnu.org
Subject: Re: [PATCH] Re: crc32 and lib.a (was Re: [PATCH] nbd in 2.5.3 does
Date: Thu, 31 Jan 2002 20:25:09 -0800 (PST) [thread overview]
Message-ID: <20020131.202509.78710127.davem@redhat.com> (raw)
In-Reply-To: <20020131224635.F21864@havoc.gtf.org>
In-Reply-To: <E16WRmu-0003iO-00@the-village.bc.nu> <20020131.163054.41634626.davem@redhat.com> <20020131224635.F21864@havoc.gtf.org>
From: Jeff Garzik <garzik@havoc.gtf.org>
Date: Thu, 31 Jan 2002 22:46:35 -0500
Maybe not in this hypothetical future situation, but currently makefile
magic was added for crc32 specifically to ensure that it is linked
in when needed... even when CONFIG_CRC32=n.
The Config.in for crc32 only exists for the case where no driver in the
built kernel uses it... but a 3rd party module might want it.
My point is this: Having to say something like "CONFIG_INEED_CRC32"
for each driver that needs it is just plain stupid and a total eye
sore.
It would be really great if, some day, you just add your source
file(s) to drivers/net and that is the only thing you ever touch. You
DO NOT touch Makefiles, you DO NOT touch Config.in files, you DO NOT
add Config.help entries.
The Makefile rules are auto-generated from keys in the *.c file(s), as
are the Config.in and help entries. Ie. cp driver.[ch]
linux/drivers/net and then simply rebuild the tree.
Think of what kind of pains this would save from a maintainership
point of view. When multiple new drivers are added at once we run
into all kinds of conflict issues today, whereas my scheme would do
away with that for all cases except totally new subsystems. (but I
think that could be automated in a similar fashion as well)
I have this feeling Keith Owens is going to scream "the new build
system DOES EXACTLY THAT!" If so, that's fscking great. :-)
That is the kind of direction I'd like to see things going in. The
lib config thing checking "if LANCE or 8130TOO or ... then force CRC32
on", on the other hand, is just garbage. It is rediculious to expect
J. Random driver author to know to put junk into weird places like
that just to get at the crc32 routines.
next prev parent reply other threads:[~2002-02-01 4:27 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020131.162549.74750188.davem@redhat.com>
2002-02-01 0:42 ` [PATCH] Re: crc32 and lib.a (was Re: [PATCH] nbd in 2.5.3 does Alan Cox
2002-02-01 0:30 ` David S. Miller
2002-02-01 3:46 ` Jeff Garzik
2002-02-01 4:25 ` David S. Miller [this message]
2002-02-01 4:48 ` Jeff Garzik
2002-02-01 5:59 ` David S. Miller
2002-02-01 5:10 ` Keith Owens
2002-02-01 5:12 ` Jeff Garzik
2002-02-01 5:18 ` Keith Owens
2002-02-01 13:42 ` Horst von Brand
2002-02-03 23:34 ` Keith Owens
2002-02-04 20:14 ` Horst von Brand
2002-02-01 6:01 ` David S. Miller
2002-02-01 6:11 ` Keith Owens
2002-02-01 6:26 ` David S. Miller
2002-02-01 6:43 ` Keith Owens
2002-02-01 15:03 ` Alan Cox
2002-02-01 14:55 ` Jeff Garzik
2002-02-01 15:12 ` Petr Vandrovec
2002-02-01 15:29 ` VESA Anybody out there Martin Dalecki
2002-02-01 15:42 ` Davidovac Zoran
2002-02-01 16:21 ` Martin Dalecki
2002-02-01 16:33 ` Thomas Capricelli
2002-02-01 16:53 ` Martin Dalecki
2002-02-01 16:35 ` Sergey S. Kostyliov
2002-02-01 16:37 ` Anton Altaparmakov
2002-02-01 16:33 ` Petr Baudis
2002-02-01 17:45 ` The Candyman
2002-02-02 13:41 ` Andreas Happe
2002-02-02 21:09 ` Martin Dalecki
2002-02-05 17:05 ` Pavel Machek
2002-02-01 16:08 ` [PATCH] Re: crc32 and lib.a (was Re: [PATCH] nbd in 2.5.3 does David Woodhouse
2002-02-04 13:24 ` Horst von Brand
2002-02-05 7:51 ` Jeff Garzik
2002-02-01 4:18 ` H. Peter Anvin
2002-02-01 4:35 ` Jeff Garzik
2002-02-01 15:19 ` Alan Cox
2002-02-01 19:37 ` Rob Landley
2002-02-01 19:50 ` Jeff Garzik
2002-01-31 22:59 [PATCH] Re: crc32 and lib.a (was Re: [PATCH] nbd in 2.5.3 does not David S. Miller
2002-01-31 23:24 ` [PATCH] Re: crc32 and lib.a (was Re: [PATCH] nbd in 2.5.3 does Alan Cox
2002-01-31 23:21 ` Arnaldo Carvalho de Melo
2002-02-02 16:32 ` Denis Vlasenko
2002-02-02 12:57 ` Jens Axboe
2002-02-02 13:16 ` arjan
2002-02-02 13:52 ` Jens Axboe
2002-02-03 11:37 ` David Woodhouse
2002-01-31 23:43 ` Jeff Garzik
2002-01-31 23:45 ` David S. Miller
2002-02-01 0:32 ` Alan Cox
2002-02-01 10:07 ` Horst von Brand
2002-02-01 10:28 ` Keith Owens
2002-02-01 11:03 ` David S. Miller
2002-02-01 11:25 ` Keith Owens
2002-02-01 14:56 ` Jeff Garzik
2002-02-01 8:14 ` David Woodhouse
2002-02-02 2:12 ` Chris Wedgwood
2002-02-02 3:01 ` Andrew Morton
2002-02-02 7:30 ` Chris Wedgwood
2002-02-02 7:42 ` Daniel Jacobowitz
2002-02-02 8:08 ` Jeff Garzik
2002-02-02 19:20 ` Daniel Jacobowitz
2002-02-02 8:06 ` Jeff Garzik
2002-02-02 8:08 ` Keith Owens
2002-02-02 8:40 ` David Woodhouse
2002-02-02 8:59 ` Keith Owens
2002-02-02 9:14 ` David Woodhouse
2002-02-03 4:14 ` Eric W. Biederman
2002-02-03 7:01 ` Ralf Baechle
2002-02-03 9:13 ` Chris Wedgwood
2002-02-03 12:16 ` David Woodhouse
2002-02-03 12:33 ` Chris Wedgwood
2002-02-03 12:47 ` David Woodhouse
2002-02-03 13:40 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020131.202509.78710127.davem@redhat.com \
--to=davem@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davidm@hpl.hp.com \
--cc=garzik@havoc.gtf.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=ralf@gnu.org \
--cc=torvalds@transmeta.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox