Re: [PATCH] Q40 input api support.

[Richard Zidlicky <Richard.Zidlicky@stud.informatik.uni-erlangen.de>]

On Thu, Jan 31, 2002 at 10:19:46AM -0800, James Simmons wrote:
> 
> This patch ports q40 PS/2 controller support over to the input api. Please
> try it out. It is against the latest dave jones tree.

thanks, I will look at this over the weekend. Where do I get the DJ
tree?

> +static inline void q40kbd_write(unsigned char val)
> +{
> +	/* FIXME! We need a way how to write to the keyboard! */
> +}

absolutely no way to write to the keyboard.

> +
> +static struct serio q40kbd_port =
> +{
> +	type:   SERIO_8042,
> +	write:  q40kbd_write,
> +	name:	"Q40 PS/2 kbd port",
> +	phys:	"isa0060/serio0",
> +};
> +
> +static void q40kbd_interrupt(int irq, void *dev_id, struct pt_regs *regs)
> +{
> +	unsigned long flags;
> +
> +	if (IRQ_KEYB_MASK & master_inb(INTERRUPT_REG))
> +		if (q40kbd_port.dev)
> +                         q40kbd_port.dev->interrupt(&q40kbd_port, master_inb(KEYCODE_REG), 0);
                                             ^^^^^^^^^
where is this defined?

> +void __init q40kbd_init(void)
> +{
> +	int maxread = 100;
> +
> +	/* Get the keyboard controller registers (incomplete decode) */
> +	request_region(0x60, 16, "q40kbd");
> +
> +	/* allocate the IRQ */
> +	request_irq(Q40_IRQ_KEYBOARD, keyboard_interrupt, 0, "q40kbd", NULL);
				      ^^^^^^^^^^^^^^^^^^
should that be q40kbd_interrupt ?

Bye
Richard